From 97f7cb805f7ebf67b10cee9e4e593f34c49d2afe Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 6 Feb 2025 09:55:30 -0500 Subject: [PATCH] LibJS: Remove errant invocation to FormatNumericUnits This is an editorial change in the Intl.DurationFormat proposal. See: https://github.com/tc39/proposal-intl-duration-format/commit/cdef892 --- Libraries/LibJS/Runtime/Intl/DurationFormat.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp b/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp index 88c22e79069..08e4a1991f4 100644 --- a/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp +++ b/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp @@ -923,18 +923,14 @@ Vector partition_duration_format_pattern(VM& vm, DurationFor // e. If style is "numeric" or "2-digit", then if (style == DurationFormat::ValueStyle::Numeric || style == DurationFormat::ValueStyle::TwoDigit) { - // i. Append FormatNumericUnits(durationFormat, duration, unit, signDisplayed) to result. - // FIXME: Spec issue: This step should have been removed. See: - // https://github.com/tc39/proposal-intl-duration-format/issues/225 - - // ii. Let numericPartsList be FormatNumericUnits(durationFormat, duration, unit, signDisplayed). + // i. Let numericPartsList be FormatNumericUnits(durationFormat, duration, unit, signDisplayed). auto numeric_parts_list = format_numeric_units(vm, duration_format, duration, unit, sign_displayed); - // iii. If numericPartsList is not empty, append numericPartsList to result. + // ii. If numericPartsList is not empty, append numericPartsList to result. if (!numeric_parts_list.is_empty()) result.append(move(numeric_parts_list)); - // iv. Set numericUnitFound to true. + // iii. Set numericUnitFound to true. numeric_unit_found = true; } // f. Else,