mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-28 23:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibHTML: Add support for <body bgcolor="#rrggbb" text="#rrggbb">

Browse source 
This patch implements basic support for presentational hints, which are
old-school HTML attributes that affect style.

You add support for a presentational hint attribute by overriding
Element::apply_presentational_hints(StyleProperties&) and setting all
of the corresponding CSS properties as appropriate.

To make the background color fill the entire document, not just the
bounds of the <body> element's LayoutNode, we special-case it in the
HtmlView::paint_event() code for now. I'm not entirely sure what the
nicest solution would be, but I'm sure we'll discover it eventually.
This commit is contained in:
Andreas Kling 2019-10-04 21:05:52 +02:00
parent a7ca719c4e
commit 9808d35554
Notes: sideshowbarker 2024-07-19 11:49:18 +09:00
12 changed files with 94 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Libraries/LibHTML/DOM/HTMLBodyElement.cpp Normal file
View file

@ -0,0 +1,27 @@
#include <LibHTML/CSS/StyleProperties.h>
#include <LibHTML/CSS/StyleValue.h>
#include <LibHTML/DOM/HTMLBodyElement.h>
HTMLBodyElement::HTMLBodyElement(Document& document, const String& tag_name)
: HTMLElement(document, tag_name)
{
}
HTMLBodyElement::~HTMLBodyElement()
{
}
void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const
{
for_each_attribute([&](auto& name, auto& value) {
if (name == "bgcolor") {
auto color = Color::from_string(value);
if (color.has_value())
style.set_property("background-color", ColorStyleValue::create(color.value()));
} else if (name == "text") {
auto color = Color::from_string(value);
if (color.has_value())
style.set_property("color", ColorStyleValue::create(color.value()));
}
});
}