mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-22 09:18:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

test-web: Wait for crash tests with a test-wait attribute

Browse source 
Similar to ref tests, we don't want to incorrectly pass a test that did
not remove this attribute.
This commit is contained in:
Timothy Flynn 2025-09-10 09:33:13 -04:00 • committed by Sam Atkins
commit 98c7a011d4
Notes: github-actions[bot] 2025-09-10 15:39:28 +00:00
1 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

72
Tests/LibWeb/test-web/main.cpp
View file

@ -159,6 +159,40 @@ static void clear_test_callbacks(TestWebView& view)
view.on_web_content_crashed = {}; view.on_web_content_crashed = {};
} }
static String generate_wait_for_test_string(StringView wait_class)
{
return MUST(String::formatted(R"(
function hasTestWaitClass() {{
return document.documentElement.classList.contains('{}');
}}
if (!hasTestWaitClass()) {{
document.fonts.ready.then(() => {{
requestAnimationFrame(function() {{
requestAnimationFrame(function() {{
internals.signalTestIsDone("PASS");
}});
}});
}});
}} else {{
const observer = new MutationObserver(() => {{
if (!hasTestWaitClass()) {{
internals.signalTestIsDone("PASS");
}}
}});
observer.observe(document.documentElement, {{
attributes: true,
attributeFilter: ['class'],
}});
}}
)"sv,
wait_class));
}
static auto wait_for_crash_test_completion = generate_wait_for_test_string("test-wait"sv);
static auto wait_for_reftest_completion = generate_wait_for_test_string("reftest-wait"sv);
static void run_dump_test(TestWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds) static void run_dump_test(TestWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds)
{ {
auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() { auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() {
@ -292,17 +326,10 @@ static void run_dump_test(TestWebView& view, Test& test, URL::URL const& url, in
// We don't want subframe loads to trigger the test finish. // We don't want subframe loads to trigger the test finish.
if (!url.equals(loaded_url, URL::ExcludeFragment::Yes)) if (!url.equals(loaded_url, URL::ExcludeFragment::Yes))
return; return;
test.did_finish_loading = true; test.did_finish_loading = true;
static String wait_for_crash_test_completion = R"(
document.fonts.ready.then(() => {
requestAnimationFrame(function() {
requestAnimationFrame(function() {
internals.signalTestIsDone("PASS");
});
});
});
)"_string;
view.run_javascript(wait_for_crash_test_completion); view.run_javascript(wait_for_crash_test_completion);
if (test.did_finish_test) if (test.did_finish_test)
on_test_complete(); on_test_complete();
}; };
@ -330,33 +357,6 @@ static void run_dump_test(TestWebView& view, Test& test, URL::URL const& url, in
timer->start(); timer->start();
} }
static String wait_for_reftest_completion = R"(
function hasReftestWaitClass() {
return document.documentElement.classList.contains('reftest-wait');
}
if (!hasReftestWaitClass()) {
document.fonts.ready.then(() => {
requestAnimationFrame(function() {
requestAnimationFrame(function() {
internals.signalTestIsDone("PASS");
});
});
});
} else {
const observer = new MutationObserver(() => {
if (!hasReftestWaitClass()) {
internals.signalTestIsDone("PASS");
}
});
observer.observe(document.documentElement, {
attributes: true,
attributeFilter: ['class'],
});
}
)"_string;
static void run_ref_test(TestWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds) static void run_ref_test(TestWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds)
{ {
auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() { auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() {