From 98df4c2b3c7d2a1606f1d02fac9e62b4f9a50662 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Tue, 3 Dec 2024 15:26:10 +0100 Subject: [PATCH] LibWeb: Make Editing::fix_disallowed_ancestors_of_node() take a GC::Ref --- Libraries/LibWeb/Editing/Commands.cpp | 2 +- Libraries/LibWeb/Editing/Internal/Algorithms.cpp | 2 +- Libraries/LibWeb/Editing/Internal/Algorithms.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/Editing/Commands.cpp b/Libraries/LibWeb/Editing/Commands.cpp index 18d45f9d650..405efd2f5c8 100644 --- a/Libraries/LibWeb/Editing/Commands.cpp +++ b/Libraries/LibWeb/Editing/Commands.cpp @@ -206,7 +206,7 @@ bool command_delete_action(DOM::Document& document, String const&) } // 7. Fix disallowed ancestors of node. - fix_disallowed_ancestors_of_node(node); + fix_disallowed_ancestors_of_node(*node); // 8. Return true. return true; diff --git a/Libraries/LibWeb/Editing/Internal/Algorithms.cpp b/Libraries/LibWeb/Editing/Internal/Algorithms.cpp index efd3106f89b..07d27a1107f 100644 --- a/Libraries/LibWeb/Editing/Internal/Algorithms.cpp +++ b/Libraries/LibWeb/Editing/Internal/Algorithms.cpp @@ -374,7 +374,7 @@ GC::Ptr editing_host_of_node(GC::Ref node) } // https://w3c.github.io/editing/docs/execCommand/#fix-disallowed-ancestors -void fix_disallowed_ancestors_of_node(GC::Ptr node) +void fix_disallowed_ancestors_of_node(GC::Ref node) { // 1. If node is not editable, abort these steps. if (!node->is_editable()) diff --git a/Libraries/LibWeb/Editing/Internal/Algorithms.h b/Libraries/LibWeb/Editing/Internal/Algorithms.h index 8b67bfcd6e3..2f64b0c51de 100644 --- a/Libraries/LibWeb/Editing/Internal/Algorithms.h +++ b/Libraries/LibWeb/Editing/Internal/Algorithms.h @@ -25,7 +25,7 @@ String canonical_space_sequence(u32 length, bool non_breaking_start, bool non_br void canonicalize_whitespace(GC::Ref, u32 offset, bool fix_collapsed_space = true); void delete_the_selection(Selection::Selection const&); GC::Ptr editing_host_of_node(GC::Ref); -void fix_disallowed_ancestors_of_node(GC::Ptr); +void fix_disallowed_ancestors_of_node(GC::Ref); bool follows_a_line_break(GC::Ref); bool is_allowed_child_of_node(Variant, FlyString> child, Variant, FlyString> parent); bool is_block_boundary_point(GC::Ref, u32 offset);