From 9a4bb958acb8dea2857a2c1eb6cad7db3438f43e Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 12 Feb 2025 08:57:20 -0500 Subject: [PATCH] LibCore: Remove ErrorOr return type from read_long_version_string Nothing in this function is fallible. --- Libraries/LibCore/ArgsParser.cpp | 2 +- Libraries/LibCore/Version.cpp | 2 +- Libraries/LibCore/Version.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibCore/ArgsParser.cpp b/Libraries/LibCore/ArgsParser.cpp index d29b8c13e77..3d37d9d7cf4 100644 --- a/Libraries/LibCore/ArgsParser.cpp +++ b/Libraries/LibCore/ArgsParser.cpp @@ -384,7 +384,7 @@ void ArgsParser::print_version(FILE* file) { // FIXME: Allow applications to override version string for --version. // Especially useful for Lagom applications - outln(file, Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors()); + outln(file, Core::Version::read_long_version_string()); } void ArgsParser::add_option(Option&& option) diff --git a/Libraries/LibCore/Version.cpp b/Libraries/LibCore/Version.cpp index fa9437595a6..572d8bf2d4b 100644 --- a/Libraries/LibCore/Version.cpp +++ b/Libraries/LibCore/Version.cpp @@ -10,7 +10,7 @@ namespace Core::Version { -ErrorOr read_long_version_string() +String read_long_version_string() { auto validate_git_hash = [](auto hash) { if (hash.length() < 4 || hash.length() > 40) diff --git a/Libraries/LibCore/Version.h b/Libraries/LibCore/Version.h index 0769916a5ee..22a5c174f27 100644 --- a/Libraries/LibCore/Version.h +++ b/Libraries/LibCore/Version.h @@ -11,6 +11,6 @@ namespace Core::Version { -ErrorOr read_long_version_string(); +String read_long_version_string(); }