mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibJS/Runtime/Object.cpp
View file

@ -31,10 +31,10 @@ static HashMap<GCPtr<Object const>, HashMap<DeprecatedFlyString, Object::Intrins
NonnullGCPtr<Object> Object::create(Realm& realm, Object* prototype)
{
if (!prototype)
return realm.heap().allocate<Object>(realm, realm.intrinsics().empty_object_shape());
return realm.create<Object>(realm.intrinsics().empty_object_shape());
if (prototype == realm.intrinsics().object_prototype())
return realm.heap().allocate<Object>(realm, realm.intrinsics().new_object_shape());
return realm.heap().allocate<Object>(realm, ConstructWithPrototypeTag::Tag, *prototype);
return realm.create<Object>(realm.intrinsics().new_object_shape());
return realm.create<Object>(ConstructWithPrototypeTag::Tag, *prototype);
}
NonnullGCPtr<Object> Object::create_prototype(Realm& realm, Object* prototype)
@ -42,12 +42,12 @@ NonnullGCPtr<Object> Object::create_prototype(Realm& realm, Object* prototype)
auto shape = realm.heap().allocate_without_realm<Shape>(realm);
if (prototype)
shape->set_prototype_without_transition(prototype);
return realm.heap().allocate<Object>(realm, shape);
return realm.create<Object>(shape);
}
NonnullGCPtr<Object> Object::create_with_premade_shape(Shape& shape)
{
return shape.heap().allocate<Object>(shape.realm(), shape);
return shape.realm().create<Object>(shape);
}
Object::Object(GlobalObjectTag, Realm& realm, MayInterfereWithIndexedPropertyAccess may_interfere_with_indexed_property_access)