mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/DOMURL/DOMURL.cpp
View file

@ -22,7 +22,7 @@ JS_DEFINE_ALLOCATOR(DOMURL);
JS::NonnullGCPtr<DOMURL> DOMURL::create(JS::Realm& realm, URL::URL url, JS::NonnullGCPtr<URLSearchParams> query)
{
return realm.heap().allocate<DOMURL>(realm, realm, move(url), move(query));
return realm.create<DOMURL>(realm, move(url), query);
}
// https://url.spec.whatwg.org/#api-url-parser

2
Libraries/LibWeb/DOMURL/URLSearchParams.cpp
View file

@ -127,7 +127,7 @@ Vector<QueryParam> url_decode(StringView input)
JS::NonnullGCPtr<URLSearchParams> URLSearchParams::create(JS::Realm& realm, Vector<QueryParam> list)
{
return realm.heap().allocate<URLSearchParams>(realm, realm, move(list));
return realm.create<URLSearchParams>(realm, move(list));
}
// https://url.spec.whatwg.org/#urlsearchparams-initialize

4
Libraries/LibWeb/DOMURL/URLSearchParamsIterator.cpp
View file

@ -15,7 +15,7 @@ namespace Web::Bindings {
template<>
void Intrinsics::create_web_prototype_and_constructor<URLSearchParamsIteratorPrototype>(JS::Realm& realm)
{
auto prototype = heap().allocate<URLSearchParamsIteratorPrototype>(realm, realm);
auto prototype = realm.create<URLSearchParamsIteratorPrototype>(realm);
m_prototypes.set("URLSearchParamsIterator"_fly_string, prototype);
}
@ -27,7 +27,7 @@ JS_DEFINE_ALLOCATOR(URLSearchParamsIterator);
WebIDL::ExceptionOr<JS::NonnullGCPtr<URLSearchParamsIterator>> URLSearchParamsIterator::create(URLSearchParams const& url_search_params, JS::Object::PropertyKind iteration_kind)
{
return url_search_params.heap().allocate<URLSearchParamsIterator>(url_search_params.realm(), url_search_params, iteration_kind);
return url_search_params.realm().create<URLSearchParamsIterator>(url_search_params, iteration_kind);
}
URLSearchParamsIterator::URLSearchParamsIterator(URLSearchParams const& url_search_params, JS::Object::PropertyKind iteration_kind)