mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-16 15:21:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/CloseWatcher.cpp
View file

@ -27,7 +27,7 @@ JS::NonnullGCPtr<CloseWatcher> CloseWatcher::establish(HTML::Window& window)
VERIFY(window.associated_document().is_fully_active());
// 2. Let closeWatcher be a new close watcher
auto close_watcher = window.heap().allocate<CloseWatcher>(window.realm(), window.realm());
auto close_watcher = window.realm().create<CloseWatcher>(window.realm());
// 3. Let manager be window's associated close watcher manager
auto manager = window.close_watcher_manager();