mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-14 14:21:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/DataTransfer.cpp
View file

@ -31,7 +31,7 @@ ENUMERATE_DATA_TRANSFER_EFFECTS
JS::NonnullGCPtr<DataTransfer> DataTransfer::create(JS::Realm& realm, NonnullRefPtr<DragDataStore> drag_data_store)
{
return realm.heap().allocate<DataTransfer>(realm, realm, move(drag_data_store));
return realm.create<DataTransfer>(realm, move(drag_data_store));
}
// https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer
@ -46,7 +46,7 @@ JS::NonnullGCPtr<DataTransfer> DataTransfer::construct_impl(JS::Realm& realm)
// 3. Set the dropEffect and effectAllowed to "none".
// NOTE: This is done by the default-initializers.
return realm.heap().allocate<DataTransfer>(realm, realm, move(drag_data_store));
return realm.create<DataTransfer>(realm, move(drag_data_store));
}
DataTransfer::DataTransfer(JS::Realm& realm, NonnullRefPtr<DragDataStore> drag_data_store)