mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-26 22:38:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLElement.cpp
View file

@ -211,7 +211,7 @@ JS::NonnullGCPtr<DOM::DocumentFragment> HTMLElement::rendered_text_fragment(Stri
{
// 1. Let fragment be a new DocumentFragment whose node document is document.
// Instead of creating a DocumentFragment the nodes are appended directly.
auto fragment = heap().allocate<DOM::DocumentFragment>(realm(), document());
auto fragment = realm().create<DOM::DocumentFragment>(document());
// 2. Let position be a position variable for input, initially pointing at the start of input.
// 3. Let text be the empty string.