mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-02 16:33:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/HTML/Navigator.cpp
View file

@ -24,7 +24,7 @@ JS_DEFINE_ALLOCATOR(Navigator);
JS::NonnullGCPtr<Navigator> Navigator::create(JS::Realm& realm)
{
return realm.heap().allocate<Navigator>(realm, realm);
return realm.create<Navigator>(realm);
}
Navigator::Navigator(JS::Realm& realm)
@ -73,28 +73,28 @@ void Navigator::visit_edges(Cell::Visitor& visitor)
JS::NonnullGCPtr<MimeTypeArray> Navigator::mime_types()
{
if (!m_mime_type_array)
m_mime_type_array = heap().allocate<MimeTypeArray>(realm(), realm());
m_mime_type_array = realm().create<MimeTypeArray>(realm());
return *m_mime_type_array;
}
JS::NonnullGCPtr<PluginArray> Navigator::plugins()
{
if (!m_plugin_array)
m_plugin_array = heap().allocate<PluginArray>(realm(), realm());
m_plugin_array = realm().create<PluginArray>(realm());
return *m_plugin_array;
}
JS::NonnullGCPtr<Clipboard::Clipboard> Navigator::clipboard()
{
if (!m_clipboard)
m_clipboard = heap().allocate<Clipboard::Clipboard>(realm(), realm());
m_clipboard = realm().create<Clipboard::Clipboard>(realm());
return *m_clipboard;
}
JS::NonnullGCPtr<UserActivation> Navigator::user_activation()
{
if (!m_user_activation)
m_user_activation = heap().allocate<UserActivation>(realm(), realm());
m_user_activation = realm().create<UserActivation>(realm());
return *m_user_activation;
}
@ -120,14 +120,14 @@ Optional<FlyString> Navigator::do_not_track() const
JS::NonnullGCPtr<ServiceWorkerContainer> Navigator::service_worker()
{
if (!m_service_worker_container)
m_service_worker_container = heap().allocate<ServiceWorkerContainer>(realm(), realm());
m_service_worker_container = realm().create<ServiceWorkerContainer>(realm());
return *m_service_worker_container;
}
JS::NonnullGCPtr<MediaCapabilitiesAPI::MediaCapabilities> Navigator::media_capabilities()
{
if (!m_media_capabilities)
m_media_capabilities = heap().allocate<MediaCapabilitiesAPI::MediaCapabilities>(realm(), realm());
m_media_capabilities = realm().create<MediaCapabilitiesAPI::MediaCapabilities>(realm());
return *m_media_capabilities;
}