mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-01 13:49:16 +00:00
LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>
The main motivation behind this is to remove JS specifics of the Realm from the implementation of the Heap. As a side effect of this change, this is a bit nicer to read than the previous approach, and in my opinion, also makes it a little more clear that this method is specific to a JavaScript Realm.
This commit is contained in:
parent
2a5dbedad4
commit
9b79a686eb
Notes:
github-actions[bot]
2024-11-13 21:52:48 +00:00
Author: https://github.com/shannonbooth
Commit: 9b79a686eb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2322
Reviewed-by: https://github.com/gmta
326 changed files with 697 additions and 714 deletions
|
@ -520,7 +520,7 @@ SerializedEnvironmentSettingsObject EnvironmentSettingsObject::serialize()
|
|||
JS::NonnullGCPtr<StorageAPI::StorageManager> EnvironmentSettingsObject::storage_manager()
|
||||
{
|
||||
if (!m_storage_manager)
|
||||
m_storage_manager = realm().heap().allocate<StorageAPI::StorageManager>(realm(), realm());
|
||||
m_storage_manager = realm().create<StorageAPI::StorageManager>(realm());
|
||||
return *m_storage_manager;
|
||||
}
|
||||
|
||||
|
|
|
@ -23,7 +23,7 @@ ImportMapParseResult::~ImportMapParseResult() = default;
|
|||
JS::NonnullGCPtr<ImportMapParseResult> ImportMapParseResult::create(JS::Realm& realm, ByteString const& input, URL::URL base_url)
|
||||
{
|
||||
// 1. Let result be an import map parse result whose import map is null and whose error to rethrow is null.
|
||||
auto result = realm.heap().allocate<ImportMapParseResult>(realm);
|
||||
auto result = realm.create<ImportMapParseResult>();
|
||||
|
||||
// 2. Parse an import map string given input and baseURL, catching any exceptions.
|
||||
auto import_map = parse_import_map_string(realm, input, base_url);
|
||||
|
|
|
@ -40,7 +40,7 @@ WebIDL::ExceptionOr<JS::GCPtr<JavaScriptModuleScript>> JavaScriptModuleScript::c
|
|||
// 2. Let script be a new module script that this algorithm will subsequently initialize.
|
||||
// 3. Set script's realm to realm.
|
||||
// 4. Set script's base URL to baseURL.
|
||||
auto script = realm.heap().allocate<JavaScriptModuleScript>(realm, move(base_url), filename, realm);
|
||||
auto script = realm.create<JavaScriptModuleScript>(move(base_url), filename, realm);
|
||||
|
||||
// FIXME: 5. Set script's fetch options to options.
|
||||
|
||||
|
|
|
@ -40,7 +40,7 @@ void WindowEnvironmentSettingsObject::setup(Page& page, URL::URL const& creation
|
|||
|
||||
// 3. Let settings object be a new environment settings object whose algorithms are defined as follows:
|
||||
// NOTE: See the functions defined for this class.
|
||||
auto settings_object = realm->heap().allocate<WindowEnvironmentSettingsObject>(*realm, window, move(execution_context));
|
||||
auto settings_object = realm->create<WindowEnvironmentSettingsObject>(window, move(execution_context));
|
||||
|
||||
// 4. If reservedEnvironment is non-null, then:
|
||||
if (reserved_environment) {
|
||||
|
@ -73,7 +73,7 @@ void WindowEnvironmentSettingsObject::setup(Page& page, URL::URL const& creation
|
|||
|
||||
// 7. Set realm's [[HostDefined]] field to settings object.
|
||||
// Non-Standard: We store the ESO next to the web intrinsics in a custom HostDefined object
|
||||
auto intrinsics = realm->heap().allocate<Bindings::Intrinsics>(*realm, *realm);
|
||||
auto intrinsics = realm->create<Bindings::Intrinsics>(*realm);
|
||||
auto host_defined = make<Bindings::PrincipalHostDefined>(settings_object, intrinsics, page);
|
||||
realm->set_host_defined(move(host_defined));
|
||||
|
||||
|
|
|
@ -32,7 +32,7 @@ JS::NonnullGCPtr<WorkerEnvironmentSettingsObject> WorkerEnvironmentSettingsObjec
|
|||
|
||||
// 4. Let settings object be a new environment settings object whose algorithms are defined as follows:
|
||||
// NOTE: See the functions defined for this class.
|
||||
auto settings_object = realm->heap().allocate<WorkerEnvironmentSettingsObject>(*realm, move(execution_context), worker);
|
||||
auto settings_object = realm->create<WorkerEnvironmentSettingsObject>(move(execution_context), worker);
|
||||
settings_object->target_browsing_context = nullptr;
|
||||
settings_object->m_origin = move(inherited_origin);
|
||||
|
||||
|
@ -44,7 +44,7 @@ JS::NonnullGCPtr<WorkerEnvironmentSettingsObject> WorkerEnvironmentSettingsObjec
|
|||
// FIXME: 7. Otherwise, set settings object's top-level origin to an implementation-defined value.
|
||||
|
||||
// 8. Set realm's [[HostDefined]] field to settings object.
|
||||
auto intrinsics = realm->heap().allocate<Bindings::Intrinsics>(*realm, *realm);
|
||||
auto intrinsics = realm->create<Bindings::Intrinsics>(*realm);
|
||||
auto host_defined = make<Bindings::PrincipalHostDefined>(settings_object, intrinsics, page);
|
||||
realm->set_host_defined(move(host_defined));
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue