mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-19 00:31:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Libraries/LibWeb/HTML/Scripting
ModuleScript.cpp

2
Libraries/LibWeb/HTML/Scripting/ModuleScript.cpp
View file

@ -40,7 +40,7 @@ WebIDL::ExceptionOr<JS::GCPtr<JavaScriptModuleScript>> JavaScriptModuleScript::c
// 2. Let script be a new module script that this algorithm will subsequently initialize.
// 3. Set script's realm to realm.
// 4. Set script's base URL to baseURL.
auto script = realm.heap().allocate<JavaScriptModuleScript>(realm, move(base_url), filename, realm);
auto script = realm.create<JavaScriptModuleScript>(move(base_url), filename, realm);
// FIXME: 5. Set script's fetch options to options.