mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-11 21:01:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/SharedResourceRequest.cpp
View file

@ -30,7 +30,7 @@ JS::NonnullGCPtr<SharedResourceRequest> SharedResourceRequest::get_or_create(JS:
auto& shared_resource_requests = document->shared_resource_requests();
if (auto it = shared_resource_requests.find(url); it != shared_resource_requests.end())
return *it->value;
auto request = realm.heap().allocate<SharedResourceRequest>(realm, page, url, *document);
auto request = realm.create<SharedResourceRequest>(page, url, *document);
shared_resource_requests.set(url, request);
return request;
}