mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-18 08:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/WorkerNavigator.cpp
View file

@ -17,7 +17,7 @@ JS_DEFINE_ALLOCATOR(WorkerNavigator);
JS::NonnullGCPtr<WorkerNavigator> WorkerNavigator::create(WorkerGlobalScope& global_scope)
{
return global_scope.heap().allocate<WorkerNavigator>(global_scope.realm(), global_scope);
return global_scope.realm().create<WorkerNavigator>(global_scope);
}
WorkerNavigator::WorkerNavigator(WorkerGlobalScope& global_scope)
@ -43,14 +43,14 @@ void WorkerNavigator::visit_edges(Cell::Visitor& visitor)
JS::NonnullGCPtr<MediaCapabilitiesAPI::MediaCapabilities> WorkerNavigator::media_capabilities()
{
if (!m_media_capabilities)
m_media_capabilities = heap().allocate<MediaCapabilitiesAPI::MediaCapabilities>(realm(), realm());
m_media_capabilities = realm().create<MediaCapabilitiesAPI::MediaCapabilities>(realm());
return *m_media_capabilities;
}
JS::NonnullGCPtr<ServiceWorkerContainer> WorkerNavigator::service_worker()
{
if (!m_service_worker_container)
m_service_worker_container = heap().allocate<ServiceWorkerContainer>(realm(), realm());
m_service_worker_container = realm().create<ServiceWorkerContainer>(realm());
return *m_service_worker_container;
}