mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-08 12:12:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -91,7 +91,7 @@ void execute_script(HTML::BrowsingContext const& browsing_context, ByteString bo
auto& vm = document->vm();
// 5. Let timer be a new timer.
auto timer = vm.heap().allocate<HeapTimer>(realm);
auto timer = realm.create<HeapTimer>();
// 6. If timeout is not null:
if (timeout_ms.has_value()) {
@ -148,7 +148,7 @@ void execute_async_script(HTML::BrowsingContext const& browsing_context, ByteStr
auto& vm = document->vm();
// 5. Let timer be a new timer.
auto timer = vm.heap().allocate<HeapTimer>(realm);
auto timer = realm.create<HeapTimer>();
// 6. If timeout is not null:
if (timeout_ms.has_value()) {