mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-12 19:19:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/WebIDL/DOMException.cpp
View file

@ -14,12 +14,12 @@ JS_DEFINE_ALLOCATOR(DOMException);
JS::NonnullGCPtr<DOMException> DOMException::create(JS::Realm& realm, FlyString name, String message)
{
return realm.heap().allocate<DOMException>(realm, realm, move(name), move(message));
return realm.create<DOMException>(realm, move(name), move(message));
}
JS::NonnullGCPtr<DOMException> DOMException::construct_impl(JS::Realm& realm, String message, FlyString name)
{
return realm.heap().allocate<DOMException>(realm, realm, move(name), move(message));
return realm.create<DOMException>(realm, move(name), move(message));
}
DOMException::DOMException(JS::Realm& realm, FlyString name, String message)

2
Libraries/LibWeb/WebIDL/ObservableArray.cpp
View file

@ -14,7 +14,7 @@ JS_DEFINE_ALLOCATOR(ObservableArray);
JS::NonnullGCPtr<ObservableArray> ObservableArray::create(JS::Realm& realm)
{
auto prototype = realm.intrinsics().array_prototype();
return realm.heap().allocate<ObservableArray>(realm, prototype);
return realm.create<ObservableArray>(prototype);
}
ObservableArray::ObservableArray(Object& prototype)

2
Libraries/LibWeb/WebIDL/Promise.cpp
View file

@ -254,7 +254,7 @@ void wait_for_all(JS::Realm& realm, Vector<JS::NonnullGCPtr<Promise>> const& pro
// 8. Let result be a list containing total null values.
// Handled in WaitForAllResults
auto results = realm.heap().allocate<WaitForAllResults>(realm, JS::create_heap_function(realm.heap(), move(success_steps)), total);
auto results = realm.create<WaitForAllResults>(JS::create_heap_function(realm.heap(), move(success_steps)), total);
// 9. For each promise of promises:
for (auto const& promise : promises) {