mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-17 07:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Delete schedule_style_update() and schedule_layout_update()

Browse source 
Both functions schedule HTML event loop processing but that's
unnecessary, because we schedule a rendering task that checks if
style/layout needs an update 60/s anyway.
This commit is contained in:
Aliaksandr Kalenik 2025-07-15 16:25:36 +02:00 • committed by Jelle Raaijmakers
commit 9b9acf0bd5
Notes: github-actions[bot] 2025-07-15 14:58:43 +00:00
3 changed files with 0 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Libraries/LibWeb/DOM/Document.cpp
View file

@ -861,24 +861,6 @@ void Document::set_origin(URL::Origin const& origin)
m_origin = origin; m_origin = origin;
} }
void Document::schedule_style_update()
{
if (!browsing_context())
return;
// NOTE: Update of the style is a step in HTML event loop processing.
HTML::main_thread_event_loop().schedule();
}
void Document::schedule_layout_update()
{
if (!browsing_context())
return;
// NOTE: Update of the layout is a step in HTML event loop processing.
HTML::main_thread_event_loop().schedule();
}
bool Document::is_child_allowed(Node const& node) const bool Document::is_child_allowed(Node const& node) const
{ {
switch (node.type()) { switch (node.type()) {
@ -1238,7 +1220,6 @@ void Document::invalidate_layout_tree(InvalidateLayoutTreeReason reason)
if (m_layout_root) if (m_layout_root)
dbgln_if(UPDATE_LAYOUT_DEBUG, "DROP TREE {}", to_string(reason)); dbgln_if(UPDATE_LAYOUT_DEBUG, "DROP TREE {}", to_string(reason));
tear_down_layout_tree(); tear_down_layout_tree();
schedule_layout_update();
} }
static void propagate_scrollbar_width_to_viewport(Element& root_element, Layout::Viewport& viewport) static void propagate_scrollbar_width_to_viewport(Element& root_element, Layout::Viewport& viewport)
@ -3426,8 +3407,6 @@ void Document::run_the_resize_steps()
visual_viewport_resize_event->set_is_trusted(true); visual_viewport_resize_event->set_is_trusted(true);
visual_viewport()->dispatch_event(visual_viewport_resize_event); visual_viewport()->dispatch_event(visual_viewport_resize_event);
} }
schedule_layout_update();
} }
// https://w3c.github.io/csswg-drafts/cssom-view-1/#document-run-the-scroll-steps // https://w3c.github.io/csswg-drafts/cssom-view-1/#document-run-the-scroll-steps

3
Libraries/LibWeb/DOM/Document.h
View file

@ -349,9 +349,6 @@ public:
Painting::ViewportPaintable const* paintable() const; Painting::ViewportPaintable const* paintable() const;
Painting::ViewportPaintable* paintable(); Painting::ViewportPaintable* paintable();
void schedule_style_update();
void schedule_layout_update();
GC::Ref<NodeList> get_elements_by_name(FlyString const&); GC::Ref<NodeList> get_elements_by_name(FlyString const&);
GC::Ref<HTMLCollection> applets(); GC::Ref<HTMLCollection> applets();

6
Libraries/LibWeb/DOM/Node.cpp
View file

@ -442,7 +442,6 @@ void Node::invalidate_style(StyleInvalidationReason reason)
if (is_document()) { if (is_document()) {
auto& document = static_cast<DOM::Document&>(*this); auto& document = static_cast<DOM::Document&>(*this);
document.set_needs_full_style_update(true); document.set_needs_full_style_update(true);
document.schedule_style_update();
return; return;
} }
@ -493,8 +492,6 @@ void Node::invalidate_style(StyleInvalidationReason reason)
for (auto* ancestor = parent_or_shadow_host(); ancestor; ancestor = ancestor->parent_or_shadow_host()) for (auto* ancestor = parent_or_shadow_host(); ancestor; ancestor = ancestor->parent_or_shadow_host())
ancestor->m_child_needs_style_update = true; ancestor->m_child_needs_style_update = true;
document().schedule_style_update();
} }
void Node::invalidate_style(StyleInvalidationReason reason, Vector<CSS::InvalidationSet::Property> const& properties, StyleInvalidationOptions options) void Node::invalidate_style(StyleInvalidationReason reason, Vector<CSS::InvalidationSet::Property> const& properties, StyleInvalidationOptions options)
@ -558,8 +555,6 @@ void Node::invalidate_style(StyleInvalidationReason reason, Vector<CSS::Invalida
invalidate_entire_subtree(*sibling); invalidate_entire_subtree(*sibling);
} }
} }
document().schedule_style_update();
} }
String Node::child_text_content() const String Node::child_text_content() const
@ -1703,7 +1698,6 @@ void Node::set_needs_style_update(bool value)
break; break;
ancestor->m_child_needs_style_update = true; ancestor->m_child_needs_style_update = true;
} }
document().schedule_style_update();
} }
} }