LibWeb: Move host_defined_intrinsics out of line

Author: https://github.com/shannonbooth
Commit: 9ba68c5776
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2220
Reviewed-by: https://github.com/ADKaster ✅

Userland/Libraries/LibWeb/Bindings/Intrinsics.cpp

@@ -9,6 +9,7 @@
 #include <LibJS/Runtime/NativeFunction.h>
 #include <LibJS/Runtime/Object.h>
 #include <LibWeb/Bindings/Intrinsics.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 
 namespace Web::Bindings {
 
@@ -28,4 +29,10 @@ bool Intrinsics::is_exposed(StringView name) const
     return m_constructors.contains(name) || m_prototypes.contains(name) || m_namespaces.contains(name);
 }
 
+Intrinsics& host_defined_intrinsics(JS::Realm& realm)
+{
+    VERIFY(realm.host_defined());
+    return verify_cast<Bindings::PrincipalHostDefined>(*realm.host_defined()).intrinsics;
+}
+
 }

Userland/Libraries/LibWeb/Bindings/Intrinsics.h

@@ -13,7 +13,6 @@
 #include <LibJS/Heap/Cell.h>
 #include <LibJS/Heap/Heap.h>
 #include <LibJS/Runtime/VM.h>
-#include <LibWeb/Bindings/PrincipalHostDefined.h>
 
 #define WEB_SET_PROTOTYPE_FOR_INTERFACE_WITH_CUSTOM_NAME(interface_class, interface_name)                  \
     do {                                                                                                   \
@@ -82,10 +81,7 @@ private:
     JS::NonnullGCPtr<JS::Realm> m_realm;
 };
 
-[[nodiscard]] inline Intrinsics& host_defined_intrinsics(JS::Realm& realm)
+Intrinsics& host_defined_intrinsics(JS::Realm& realm);
-{
-    return *verify_cast<PrincipalHostDefined>(realm.host_defined())->intrinsics;
-}
 
 template<typename T>
 [[nodiscard]] JS::Object& ensure_web_namespace(JS::Realm& realm, FlyString const& namespace_name)

Userland/Libraries/LibWeb/DOM/Document.cpp

@@ -27,6 +27,7 @@
 #include <LibWeb/Animations/DocumentTimeline.h>
 #include <LibWeb/Bindings/DocumentPrototype.h>
 #include <LibWeb/Bindings/MainThreadVM.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/CSS/AnimationEvent.h>
 #include <LibWeb/CSS/CSSAnimation.h>
 #include <LibWeb/CSS/CSSImportRule.h>

Userland/Libraries/LibWeb/DOM/EventTarget.cpp

@@ -15,6 +15,7 @@
 #include <LibJS/Runtime/VM.h>
 #include <LibWeb/Bindings/EventTargetPrototype.h>
 #include <LibWeb/Bindings/MainThreadVM.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/DOM/AbortSignal.h>
 #include <LibWeb/DOM/DOMEventListener.h>
 #include <LibWeb/DOM/Document.h>

Userland/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp

@@ -12,6 +12,7 @@
 #include <AK/ScopeGuard.h>
 #include <LibJS/Runtime/Completion.h>
 #include <LibWeb/Bindings/MainThreadVM.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/Cookie/Cookie.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOMURL/DOMURL.h>

Userland/Libraries/LibWeb/FileAPI/Blob.cpp

@@ -13,6 +13,7 @@
 #include <LibWeb/Bindings/BlobPrototype.h>
 #include <LibWeb/Bindings/ExceptionOrUtils.h>
 #include <LibWeb/Bindings/Intrinsics.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/FileAPI/Blob.h>
 #include <LibWeb/HTML/Scripting/TemporaryExecutionContext.h>
 #include <LibWeb/HTML/StructuredSerialize.h>

Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp

@@ -5,6 +5,7 @@
  */
 
 #include <LibWeb/Bindings/MainThreadVM.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/ElementFactory.h>
 #include <LibWeb/DOM/Event.h>

Userland/Libraries/LibWeb/HTML/HTMLDialogElement.cpp

@@ -8,6 +8,7 @@
 #include <LibJS/Runtime/NativeFunction.h>
 #include <LibWeb/Bindings/HTMLDialogElementPrototype.h>
 #include <LibWeb/Bindings/Intrinsics.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Event.h>
 #include <LibWeb/DOM/IDLEventListener.h>

Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp

@@ -13,6 +13,7 @@
 #include <LibJS/Runtime/Date.h>
 #include <LibJS/Runtime/NativeFunction.h>
 #include <LibWeb/Bindings/HTMLInputElementPrototype.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/CSS/StyleValues/CSSKeywordValue.h>
 #include <LibWeb/CSS/StyleValues/DisplayStyleValue.h>
 #include <LibWeb/CSS/StyleValues/LengthStyleValue.h>

Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp

@@ -8,6 +8,7 @@
  */
 
 #include <LibWeb/Bindings/MainThreadVM.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/Bindings/SyntheticHostDefined.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/Fetch/Infrastructure/FetchRecord.h>

Userland/Libraries/LibWeb/HTML/Scripting/WorkerEnvironmentSettingsObject.cpp

@@ -5,6 +5,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/HTML/Scripting/WorkerEnvironmentSettingsObject.h>
 #include <LibWeb/HTML/WorkerGlobalScope.h>
 #include <LibWeb/HighResolutionTime/TimeOrigin.h>

Userland/Libraries/LibWeb/HTML/SharedResourceRequest.cpp

@@ -6,6 +6,7 @@
 
 #include <AK/HashTable.h>
 #include <LibGfx/Bitmap.h>
+#include <LibWeb/Bindings/PrincipalHostDefined.h>
 #include <LibWeb/Fetch/Fetching/Fetching.h>
 #include <LibWeb/Fetch/Infrastructure/FetchAlgorithms.h>
 #include <LibWeb/Fetch/Infrastructure/FetchController.h>