mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-06 09:36:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

UI/Qt: Add a menu item to open about:settings

Browse source 
This replaces the existing menu item that would open the Qt settings
dialog. That menu item still exists, but is no longer the default
settings action.
This commit is contained in:
Timothy Flynn 2025-03-21 09:51:00 -04:00 • committed by Alexander Kalenik
commit 9bdd22c6b1
Notes: github-actions[bot] 2025-03-22 16:28:38 +00:00
1 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
UI/Qt/BrowserWindow.cpp
View file

@ -207,6 +207,21 @@ BrowserWindow::BrowserWindow(Vector<URL::URL> const& initial_urls, IsPopupWindow
settings_action->setIcon(load_icon_from_uri("resource://icons/16x16/settings.png"sv));
settings_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Preferences));
edit_menu->addAction(settings_action);
QObject::connect(settings_action, &QAction::triggered, this, [this] {
new_tab_from_url(URL::URL::about("settings"_string), Web::HTML::ActivateTab::Yes);
});
auto* deprecated_settings_action = new QAction("Qt Settings", this);
deprecated_settings_action->setIcon(load_icon_from_uri("resource://icons/16x16/settings.png"sv));
edit_menu->addAction(deprecated_settings_action);
QObject::connect(deprecated_settings_action, &QAction::triggered, this, [this] {
if (!m_settings_dialog) {
m_settings_dialog = new SettingsDialog(this);
}
m_settings_dialog->show();
m_settings_dialog->setFocus();
});
auto* view_menu = m_hamburger_menu->addMenu("&View");
menuBar()->addMenu(view_menu);
@ -641,14 +656,6 @@ BrowserWindow::BrowserWindow(Vector<URL::URL> const& initial_urls, IsPopupWindow
(void)static_cast<Ladybird::Application*>(QApplication::instance())->new_window({});
});
QObject::connect(open_file_action, &QAction::triggered, this, &BrowserWindow::open_file);
QObject::connect(settings_action, &QAction::triggered, this, [this] {
if (!m_settings_dialog) {
m_settings_dialog = new SettingsDialog(this);
}
m_settings_dialog->show();
m_settings_dialog->setFocus();
});
QObject::connect(m_tabs_container, &QTabWidget::currentChanged, [this](int index) {
auto* tab = as<Tab>(m_tabs_container->widget(index));
if (tab)