From 9c205537e1614b577d35ed4eab4443cdeb91cd57 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 23 May 2024 13:57:15 +0200 Subject: [PATCH] LibWeb: Add missing navigable null check in Document::open() I saw a null pointer dereference here on GitHub once, but don't know how to reproduce, or how we'd get here. Nevertheless, null-checking the navigable is reasonable so let's do it. --- Userland/Libraries/LibWeb/DOM/Document.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index dcbe736bc09..b6cd64091ee 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -556,7 +556,7 @@ WebIDL::ExceptionOr Document::open(Optional const&, Optional< // If document belongs to a child navigable, we need to make sure its initial navigation is done, // because subsequent steps will modify "initial about:blank" to false, which would cause // initial navigation to fail in case it was "about:blank". - if (auto navigable = this->navigable(); navigable->container() && !navigable->container()->content_navigable_initialized()) { + if (auto navigable = this->navigable(); navigable && navigable->container() && !navigable->container()->content_navigable_initialized()) { HTML::main_thread_event_loop().spin_processing_tasks_with_source_until(HTML::Task::Source::NavigationAndTraversal, [navigable_container = navigable->container()] { return navigable_container->content_navigable_initialized(); });