mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Actually run UTF-8 decode without BOM

Browse source 
This fixes a crash using URLSearchParams when provided a percent encoded
string which does not percent decode to valid UTF-8.

Fixes a crash running https://wpt.live/url/urlencoded-parser.any.html
This commit is contained in:
Shannon Booth 2024-08-10 17:56:35 +12:00 • committed by Andreas Kling
commit 9c72fc9642
Notes: github-actions[bot] 2024-08-10 08:47:22 +00:00
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/URL/search-params-with-invalid-utf8.txt Normal file
View file

@ -0,0 +1,2 @@
key equals = true
value equals = true

10
Tests/LibWeb/Text/input/URL/search-params-with-invalid-utf8.html Normal file
View file

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
test(() => {
const params = new URLSearchParams('%FE%FF');
for (const [key, value] of params) {
println(`key equals = ${"\uFFFD\uFFFD" === key}`);
println(`value equals = ${"" === value}`);
}
});
</script>

4
Userland/Libraries/LibWeb/DOMURL/URLSearchParams.cpp
View file

@ -115,8 +115,8 @@ ErrorOr<Vector<QueryParam>> url_decode(StringView input)
auto space_decoded_name = name.replace("+"sv, " "sv, ReplaceMode::All); auto space_decoded_name = name.replace("+"sv, " "sv, ReplaceMode::All);
// 5. Let nameString and valueString be the result of running UTF-8 decode without BOM on the percent-decoding of name and value, respectively. // 5. Let nameString and valueString be the result of running UTF-8 decode without BOM on the percent-decoding of name and value, respectively.
auto name_string = TRY(String::from_byte_string(URL::percent_decode(space_decoded_name))); auto name_string = String::from_utf8_with_replacement_character(URL::percent_decode(space_decoded_name));
auto value_string = TRY(String::from_byte_string(URL::percent_decode(value))); auto value_string = String::from_utf8_with_replacement_character(URL::percent_decode(value));
TRY(output.try_empend(move(name_string), move(value_string))); TRY(output.try_empend(move(name_string), move(value_string)));
} }