mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 19:59:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Abort ongoing navigations when firing certain navigate events

Browse source 
Implements specification change:

335d7f4

Which fixes a crash in the imported test.
This commit is contained in:
Shannon Booth 2025-07-05 16:59:55 +12:00 • committed by Alexander Kalenik
commit 9e3a476890
Notes: github-actions[bot] 2025-07-06 19:45:12 +00:00
3 changed files with 60 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -1320,26 +1320,35 @@ bool Navigation::fire_a_push_replace_reload_navigate_event(
if (!navigation_api_state.has_value())
navigation_api_state = MUST(structured_serialize_for_storage(vm, JS::js_null()));
// 1. Let event be the result of creating an event given NavigateEvent, in navigation's relevant realm.
// 2. Set event's classic history API state to classicHistoryAPIState.
// 1. If isSameDocument is true:
if (is_same_document) {
// 1. While navigation's ongoing navigate event is not null:
while (m_ongoing_navigate_event) {
// 1. Abort the ongoing navigation given navigation.
abort_the_ongoing_navigation();
}
}
// 2. Let event be the result of creating an event given NavigateEvent, in navigation's relevant realm.
// 3. Set event's classic history API state to classicHistoryAPIState.
// AD-HOC: These are handled in the inner algorithm
// 3. Let destination be a new NavigationDestination created in navigation's relevant realm.
// 4. Let destination be a new NavigationDestination created in navigation's relevant realm.
auto destination = NavigationDestination::create(realm);
// 4. Set destination's URL to destinationURL.
// 5. Set destination's URL to destinationURL.
destination->set_url(destination_url);
// 5. Set destination's entry to null.
// 6. Set destination's entry to null.
destination->set_entry(nullptr);
// 6. Set destination's state to navigationAPIState.
// 7. Set destination's state to navigationAPIState.
destination->set_state(*navigation_api_state);
// 7. Set destination's is same document to isSameDocument.
// 8. Set destination's is same document to isSameDocument.
destination->set_is_same_document(is_same_document);
// 8. Return the result of performing the inner navigate event firing algorithm given navigation,
// 9. Return the result of performing the inner navigate event firing algorithm given navigation,
// navigationType, event, destination, userInvolvement, sourceElement, formDataEntryList, and null.
// AD-HOC: We don't pass the event, but we do pass the classic_history_api state at the end to be set later
return inner_navigate_event_firing_algorithm(navigation_type, destination, user_involvement, source_element, move(form_data_entry_list), {}, move(classic_history_api_state));

6
Tests/LibWeb/Text/expected/wpt-import/navigation-api/navigate-event/navigate-multiple-history-pushState.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass history.pushState() called multiple times gives correct event order

37
Tests/LibWeb/Text/input/wpt-import/navigation-api/navigate-event/navigate-multiple-history-pushState.html Normal file
View file

@ -0,0 +1,37 @@
<!doctype html>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script>
async_test(t => {
const expected = [
"navigate #1",
"navigateerror #1",
"navigate #3",
"navigateerror #3",
"navigate #2",
"navigatesuccess #2"
];
const result = [];
navigation.onnavigate = t.step_func(e => {
result.push(`${e.type} ${new URL(e.destination.url).hash}`);
});
navigation.onnavigateerror = t.step_func(e => {
result.push(`${e.type} ${new URL(navigation.currentEntry.url).hash}`);
if (navigation.currentEntry.url.endsWith("#1")) {
history.pushState(1, null, "#3");
}
});
navigation.onnavigatesuccess = t.step_func_done(e => {
result.push(`${e.type} ${new URL(navigation.currentEntry.url).hash}`);
assert_array_equals(result, expected);
});
history.pushState(1, null, "#1");
history.pushState(1, null, "#2");
}, "history.pushState() called multiple times gives correct event order");
</script>