From 9ee061ea14e88e03752f10d89af6791cbb2985b8 Mon Sep 17 00:00:00 2001 From: Jamie Mansfield Date: Thu, 23 May 2024 22:53:03 +0100 Subject: [PATCH] LibWeb: Implement HTMLImageElement.loading Removes some console noise while loading mmu.ac.uk :) --- .../Text/expected/HTML/img-element-loading.txt | 5 +++++ .../Text/input/HTML/img-element-loading.html | 18 ++++++++++++++++++ .../Libraries/LibWeb/HTML/HTMLImageElement.idl | 3 ++- 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 Tests/LibWeb/Text/expected/HTML/img-element-loading.txt create mode 100644 Tests/LibWeb/Text/input/HTML/img-element-loading.html diff --git a/Tests/LibWeb/Text/expected/HTML/img-element-loading.txt b/Tests/LibWeb/Text/expected/HTML/img-element-loading.txt new file mode 100644 index 00000000000..4bb18c0fa8b --- /dev/null +++ b/Tests/LibWeb/Text/expected/HTML/img-element-loading.txt @@ -0,0 +1,5 @@ + loading = eager + +loading = lazy + +loading = eager diff --git a/Tests/LibWeb/Text/input/HTML/img-element-loading.html b/Tests/LibWeb/Text/input/HTML/img-element-loading.html new file mode 100644 index 00000000000..7a7e94635f2 --- /dev/null +++ b/Tests/LibWeb/Text/input/HTML/img-element-loading.html @@ -0,0 +1,18 @@ + + + diff --git a/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl index 5f4e26749b9..762a93a78e3 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl +++ b/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl @@ -1,4 +1,5 @@ #import +#import // https://html.spec.whatwg.org/multipage/embedded-content.html#htmlimageelement [Exposed=Window, LegacyFactoryFunction=Image(optional unsigned long width, optional unsigned long height)] @@ -21,7 +22,7 @@ interface HTMLImageElement : HTMLElement { [FIXME] readonly attribute USVString currentSrc; [FIXME, CEReactions] attribute DOMString referrerPolicy; [FIXME, CEReactions] attribute DOMString decoding; - [FIXME, CEReactions] attribute DOMString loading; + [CEReactions, Enumerated=LazyLoadingAttribute, Reflect] attribute DOMString loading; [FIXME, CEReactions] attribute DOMString fetchPriority; [FIXME] Promise decode();