mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 21:29:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Ensure a font source format() only contains one string/ident

Browse source
This commit is contained in:
Sam Atkins 2025-04-15 11:04:04 +01:00 • committed by Andreas Kling
commit 9f333c424c
Notes: github-actions[bot] 2025-04-15 19:41:39 +00:00
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/Parser/ValueParsing.cpp
View file

@ -3711,6 +3711,12 @@ RefPtr<FontSourceStyleValue> Parser::parse_font_source_value(TokenStream<Compone
return nullptr; return nullptr;
} }
format_tokens.discard_whitespace();
if (format_tokens.has_next_token()) {
dbgln_if(CSS_PARSER_DEBUG, "CSSParser: font source invalid (`format()` has trailing tokens); discarding.");
return nullptr;
}
format = move(format_name); format = move(format_name);
} }

10
Tests/LibWeb/Text/expected/wpt-import/css/css-fonts/parsing/font-face-src-format.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 35 tests Found 35 tests
30 Pass 33 Pass
5 Fail 2 Fail
Pass Check that src: url("foo.ttf") is valid Pass Check that src: url("foo.ttf") is valid
Pass Check that src: url("foo.ttf"), url("bar.ttf") is valid Pass Check that src: url("foo.ttf"), url("bar.ttf") is valid
Pass Check that src: url("foo.ttf") format() is invalid Pass Check that src: url("foo.ttf") format() is invalid
@ -15,14 +15,14 @@ Pass Check that src: url("foo.ttf") format("opentype") is valid
Pass Check that src: url("foo.ttf") format("truetype") is valid Pass Check that src: url("foo.ttf") format("truetype") is valid
Pass Check that src: url("foo.ttf") format("woff") is valid Pass Check that src: url("foo.ttf") format("woff") is valid
Pass Check that src: url("foo.ttf") format("woff2") is valid Pass Check that src: url("foo.ttf") format("woff2") is valid
Fail Check that src: url("foo.ttf") format("opentype", "truetype") is invalid Pass Check that src: url("foo.ttf") format("opentype", "truetype") is invalid
Fail Check that src: url("foo.ttf") format(collection) is valid Fail Check that src: url("foo.ttf") format(collection) is valid
Pass Check that src: url("foo.ttf") format(opentype) is valid Pass Check that src: url("foo.ttf") format(opentype) is valid
Pass Check that src: url("foo.ttf") format(truetype) is valid Pass Check that src: url("foo.ttf") format(truetype) is valid
Pass Check that src: url("foo.ttf") format(woff) is valid Pass Check that src: url("foo.ttf") format(woff) is valid
Pass Check that src: url("foo.ttf") format(woff2) is valid Pass Check that src: url("foo.ttf") format(woff2) is valid
Fail Check that src: url("foo.ttf") format(opentype, truetype) is invalid Pass Check that src: url("foo.ttf") format(opentype, truetype) is invalid
Fail Check that src: url("foo.ttf") format(opentype truetype) is invalid Pass Check that src: url("foo.ttf") format(opentype truetype) is invalid
Pass Check that src: url("foo.ttf") format(auto) is invalid Pass Check that src: url("foo.ttf") format(auto) is invalid
Pass Check that src: url("foo.ttf") format(default) is invalid Pass Check that src: url("foo.ttf") format(default) is invalid
Pass Check that src: url("foo.ttf") format(inherit) is invalid Pass Check that src: url("foo.ttf") format(inherit) is invalid