mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-24 18:02:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Handle non-OK network responses in <object> elements
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
We were previously only testing for network errors, which includes e.g.
DNS resolution and connection errors. It does not include e.g. HTTP 404
responses, which is exercised by Acid 2.
This commit is contained in:
Timothy Flynn 2025-05-21 12:26:31 -04:00 • committed by Andrew Kaster
parent fc204c8732
commit 9f3526b080
Notes: github-actions[bot] 2025-05-21 18:14:26 +00:00
3 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -297,7 +297,7 @@ void HTMLObjectElement::queue_element_task_to_run_object_representation_steps()
auto& realm = this->realm();
auto& global = document().realm().global_object();
if (response->is_network_error()) {
if (response->is_network_error() || !Fetch::Infrastructure::is_ok_status(response->status())) {
resource_did_fail();
return;
}

14
Tests/LibWeb/Layout/expected/object-fallback.txt Normal file
View file

@ -0,0 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x34 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x18 children: inline
InlineNode <object>
frag 0 from TextNode start: 1, length: 23, rect: [8,8 181.5x18] baseline: 13.796875
"This should be visible!"
TextNode <#text>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x34]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x18]
PaintableWithLines (InlineNode<OBJECT>)
TextPaintable (TextNode<#text>)

5
Tests/LibWeb/Layout/input/object-fallback.html Normal file
View file

@ -0,0 +1,5 @@
<!doctype html>
<!-- For testing purposes, this must be a domain name that resolves and results in a non-200 HTTP response -->
<object data="https://ladybird.org/does-not-exist.html" type="text/html">
This should be visible!
</object>