mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-21 09:49:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Allow stacking context to only be created by PaintableBox

Browse source 
For a while we used the wider Paintable type for stacking context,
because it was allowed to be created by InlinePaintable and
PaintableBox. Now, when InlinePaintable type is gone, we can use more
specific PaintableBox type for a stacking context.
This commit is contained in:
Aliaksandr Kalenik 2024-11-18 16:05:22 +01:00 • committed by Andreas Kling
commit 9f541c363d
Notes: github-actions[bot] 2024-11-18 19:08:27 +00:00
7 changed files with 103 additions and 120 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/Painting/StackingContext.h
View file

@ -16,13 +16,12 @@ class StackingContext {
friend class ViewportPaintable;
public:
StackingContext(Paintable&, StackingContext* parent, size_t index_in_tree_order);
StackingContext(PaintableBox&, StackingContext* parent, size_t index_in_tree_order);
StackingContext* parent() { return m_parent; }
StackingContext const* parent() const { return m_parent; }
Paintable const& paintable() const { return *m_paintable; }
PaintableBox const& paintable_box() const { return verify_cast<PaintableBox>(*m_paintable); }
PaintableBox const& paintable_box() const { return *m_paintable; }
enum class StackingContextPaintPhase {
BackgroundAndBorders,
@ -48,14 +47,14 @@ public:
void set_last_paint_generation_id(u64 generation_id);
private:
GC::Ref<Paintable> m_paintable;
GC::Ref<PaintableBox> m_paintable;
StackingContext* const m_parent { nullptr };
Vector<StackingContext*> m_children;
size_t m_index_in_tree_order { 0 };
Optional<u64> m_last_paint_generation_id;
Vector<GC::Ref<Paintable const>> m_positioned_descendants_and_stacking_contexts_with_stack_level_0;
Vector<GC::Ref<Paintable const>> m_non_positioned_floating_descendants;
Vector<GC::Ref<PaintableBox const>> m_positioned_descendants_and_stacking_contexts_with_stack_level_0;
Vector<GC::Ref<PaintableBox const>> m_non_positioned_floating_descendants;
static void paint_child(PaintContext&, StackingContext const&);
void paint_internal(PaintContext&) const;