mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-09-13 13:02:28 +00:00
DevTools+LibJS+LibWeb: Change class_name to use StringView
This helps make the overall codebase consistent. `class_name()` in `Kernel` is always `StringView`, but not elsewhere. Additionally, this results in the `strlen` (which needs to be done when printing or other operations) always being computed at compile-time.
This commit is contained in:
parent
5b7a5b3c01
commit
a0367aa43b
Notes:
sideshowbarker
2024-07-17 17:08:50 +09:00
Author: https://github.com/ldm5180
Commit: a0367aa43b
Pull-request: https://github.com/SerenityOS/serenity/pull/13084
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/tomuta
17 changed files with 37 additions and 20 deletions
|
@ -7,6 +7,7 @@
|
|||
#pragma once
|
||||
|
||||
#include <AK/String.h>
|
||||
#include <AK/StringView.h>
|
||||
#include <LibJS/Heap/Cell.h>
|
||||
|
||||
namespace JS {
|
||||
|
@ -25,7 +26,7 @@ public:
|
|||
String to_string() const { return String::formatted("Symbol({})", description()); }
|
||||
|
||||
private:
|
||||
virtual const char* class_name() const override { return "Symbol"; }
|
||||
virtual StringView class_name() const override { return "Symbol"sv; }
|
||||
|
||||
Optional<String> m_description;
|
||||
bool m_is_global;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue