mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 08:39:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash on CSS all: revert

Browse source 
Not every value in a StyleProperties will be non-null by the time we
perform `revert`, so let's make a specialized function for reverting a
property instead of using the path that requires the value to be
non-null.
This commit is contained in:
Andreas Kling 2024-08-04 10:08:28 +02:00 • committed by Andreas Kling
commit a10610a1ca
Notes: github-actions[bot] 2024-08-04 09:50:34 +00:00
5 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -859,13 +859,7 @@ void StyleComputer::set_all_properties(DOM::Element& element, Optional<CSS::Sele
auto property_id = (CSS::PropertyID)i;
if (value.is_revert()) {
style.set_property(
property_id,
style_for_revert.property(property_id),
style_for_revert.is_property_inherited(property_id)
? StyleProperties::Inherited::Yes
: StyleProperties::Inherited::No,
important);
style.revert_property(property_id, style_for_revert);
continue;
}