mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-11 12:06:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Move property code from CSSStyleDeclaration to *Properties

Browse source 
CSSStyleDeclaration is a base class that's used by various collections
of style properties or descriptors. This commit moves all
style-property-related code into CSSStyleProperties, where it belongs.

As noted in the previous commit, we also apply the CSSStyleProperties
prototype now.
This commit is contained in:
Sam Atkins 2025-03-18 14:07:08 +00:00
commit a28197669a
Notes: github-actions[bot] 2025-03-19 13:54:14 +00:00
12 changed files with 276 additions and 295 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/CSSOMView/getClientRects-in-detached-document.txt
View file

@ -1,3 +1,3 @@
[object CSSStyleDeclaration]
[object CSSStyleProperties]
[object DOMRectList]
PASS (didn't crash)

12
Tests/LibWeb/Text/expected/css/CSSStyleDeclaration-all-supported-properties-and-default-values.txt → Tests/LibWeb/Text/expected/css/CSSStyleProperties-all-supported-properties-and-default-values.txt
View file

@ -1,7 +1,4 @@
All supported properties and their default values exposed from CSSStyleDeclaration from getComputedStyle:
'cssText': ''
'length': '232'
'parentRule': 'null'
All supported properties and their default values exposed from CSSStyleProperties from getComputedStyle:
'cssFloat': 'none'
'WebkitAlignContent': 'normal'
'webkitAlignContent': 'normal'
@ -641,9 +638,4 @@ All supported properties and their default values exposed from CSSStyleDeclarati
'y': '0px'
'zIndex': 'auto'
'z-index': 'auto'
'getPropertyPriority': 'function getPropertyPriority() { [native code] }'
'getPropertyValue': 'function getPropertyValue() { [native code] }'
'removeProperty': 'function removeProperty() { [native code] }'
'item': 'function item() { [native code] }'
'setProperty': 'function setProperty() { [native code] }'
'constructor': 'function CSSStyleDeclaration() { [native code] }'
'constructor': 'function CSSStyleProperties() { [native code] }'

2
Tests/LibWeb/Text/expected/css/style-declaration-parent-rule.txt
View file

@ -1,4 +1,4 @@
spanRule: [object CSSStyleRule] ~ span { color: purple; }
spanRule.style: [object CSSStyleDeclaration] ~ span { color: purple; }
spanRule.style: [object CSSStyleProperties] ~ span { color: purple; }
spanRule.style.parentRule: [object CSSStyleRule] ~ span { color: purple; }
spanRule.style.parentRule === spanRule: true

2
Tests/LibWeb/Text/input/css/CSSStyleDeclaration-all-supported-properties-and-default-values.html → Tests/LibWeb/Text/input/css/CSSStyleProperties-all-supported-properties-and-default-values.html
View file

@ -10,7 +10,7 @@
const stylePrototype = Object.getPrototypeOf(defaultStyle);
const supportedProperties = Object.getOwnPropertyNames(stylePrototype);
println("All supported properties and their default values exposed from CSSStyleDeclaration from getComputedStyle:");
println("All supported properties and their default values exposed from CSSStyleProperties from getComputedStyle:");
for (const supportedProperty of supportedProperties) {
println(`'${supportedProperty}': '${defaultStyle[supportedProperty]}'`);
}