mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 08:39:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Don't assume that animations have an associated effect

Browse source 
... when computing properties.
This commit is contained in:
Lucas CHOLLET 2024-12-22 21:29:02 -05:00 • committed by Andreas Kling
commit a2ab3769f4
Notes: github-actions[bot] 2024-12-25 16:15:08 +00:00
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1125,6 +1125,9 @@ void StyleComputer::collect_animation_into(DOM::Element& element, Optional<CSS::
static void apply_animation_properties(DOM::Document& document, CascadedProperties& cascaded_properties, Animations::Animation& animation) static void apply_animation_properties(DOM::Document& document, CascadedProperties& cascaded_properties, Animations::Animation& animation)
{ {
if (!animation.effect())
return;
auto& effect = verify_cast<Animations::KeyframeEffect>(*animation.effect()); auto& effect = verify_cast<Animations::KeyframeEffect>(*animation.effect());
Optional<CSS::Time> duration; Optional<CSS::Time> duration;
@ -2410,7 +2413,8 @@ GC::Ref<ComputedProperties> StyleComputer::compute_properties(DOM::Element& elem
animation->play().release_value_but_fixme_should_propagate_errors(); animation->play().release_value_but_fixme_should_propagate_errors();
} else { } else {
// The animation hasn't changed, but some properties of the animation may have // The animation hasn't changed, but some properties of the animation may have
apply_animation_properties(m_document, cascaded_properties, *element.cached_animation_name_animation(pseudo_element)); if (auto animation = element.cached_animation_name_animation(pseudo_element); animation)
apply_animation_properties(m_document, cascaded_properties, *animation);
} }
} }
} else { } else {