mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-18 23:12:02 +00:00
LibWeb: Skip anchor activation behavior if the click event was cancelled
This commit is contained in:
Igor Pissolati
Andreas Kling
parent
cc411b328c
commit
a2bc97a9c2
Notes:
sideshowbarker
2024-07-17 21:11:12 +09:00
Author: https://github.com/Igoorx
Commit: a2bc97a9c2
Pull-request: https://github.com/SerenityOS/serenity/pull/13589
1 changed files with 51 additions and 48 deletions
|
|
@ -194,56 +194,59 @@ bool EventHandler::handle_mouseup(Gfx::IntPoint const& position, unsigned button
|
||||||
node->dispatch_event(UIEvents::MouseEvent::create(UIEvents::EventNames::mouseup, offset.x(), offset.y(), position.x(), position.y()));
|
node->dispatch_event(UIEvents::MouseEvent::create(UIEvents::EventNames::mouseup, offset.x(), offset.y(), position.x(), position.y()));
|
||||||
handled_event = true;
|
handled_event = true;
|
||||||
|
|
||||||
// FIXME: This is ad-hoc and incorrect. The reason this exists is
|
bool run_activation_behavior = true;
|
||||||
// because we are missing browsing context navigation:
|
if (node.ptr() == m_mousedown_target && button == GUI::MouseButton::Primary) {
|
||||||
//
|
run_activation_behavior = node->dispatch_event(UIEvents::MouseEvent::create(UIEvents::EventNames::click, offset.x(), offset.y(), position.x(), position.y()));
|
||||||
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate
|
|
||||||
//
|
|
||||||
// Additionally, we currently cannot spawn a new top-level
|
|
||||||
// browsing context for new tab operations, because the new
|
|
||||||
// top-level browsing context would be in another process. To
|
|
||||||
// fix this, there needs to be some way to be able to
|
|
||||||
// communicate with browsing contexts in remote WebContent
|
|
||||||
// processes, and then step 8 of this algorithm needs to be
|
|
||||||
// implemented in BrowsingContext::choose_a_browsing_context:
|
|
||||||
//
|
|
||||||
// https://html.spec.whatwg.org/multipage/browsers.html#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name
|
|
||||||
if (RefPtr<HTML::HTMLAnchorElement> link = node->enclosing_link_element()) {
|
|
||||||
NonnullRefPtr document = *m_browsing_context.active_document();
|
|
||||||
auto href = link->href();
|
|
||||||
auto url = document->parse_url(href);
|
|
||||||
dbgln("Web::EventHandler: Clicking on a link to {}", url);
|
|
||||||
if (button == GUI::MouseButton::Primary) {
|
|
||||||
if (href.starts_with("javascript:")) {
|
|
||||||
document->run_javascript(href.substring_view(11, href.length() - 11));
|
|
||||||
} else if (!url.fragment().is_null() && url.equals(document->url(), AK::URL::ExcludeFragment::Yes)) {
|
|
||||||
m_browsing_context.scroll_to_anchor(url.fragment());
|
|
||||||
} else {
|
|
||||||
if (m_browsing_context.is_top_level()) {
|
|
||||||
if (auto* page = m_browsing_context.page())
|
|
||||||
page->client().page_did_click_link(url, link->target(), modifiers);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else if (button == GUI::MouseButton::Middle) {
|
|
||||||
if (auto* page = m_browsing_context.page())
|
|
||||||
page->client().page_did_middle_click_link(url, link->target(), modifiers);
|
|
||||||
} else if (button == GUI::MouseButton::Secondary) {
|
|
||||||
if (auto* page = m_browsing_context.page())
|
|
||||||
page->client().page_did_request_link_context_menu(m_browsing_context.to_top_level_position(position), url, link->target(), modifiers);
|
|
||||||
}
|
|
||||||
} else if (button == GUI::MouseButton::Secondary) {
|
|
||||||
if (is<HTML::HTMLImageElement>(*node)) {
|
|
||||||
auto& image_element = verify_cast<HTML::HTMLImageElement>(*node);
|
|
||||||
auto image_url = image_element.document().parse_url(image_element.src());
|
|
||||||
if (auto* page = m_browsing_context.page())
|
|
||||||
page->client().page_did_request_image_context_menu(m_browsing_context.to_top_level_position(position), image_url, "", modifiers, image_element.bitmap());
|
|
||||||
} else if (auto* page = m_browsing_context.page()) {
|
|
||||||
page->client().page_did_request_context_menu(m_browsing_context.to_top_level_position(position));
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (node.ptr() == m_mousedown_target && button == GUI::MouseButton::Primary) {
|
if (run_activation_behavior) {
|
||||||
node->dispatch_event(UIEvents::MouseEvent::create(UIEvents::EventNames::click, offset.x(), offset.y(), position.x(), position.y()));
|
// FIXME: This is ad-hoc and incorrect. The reason this exists is
|
||||||
|
// because we are missing browsing context navigation:
|
||||||
|
//
|
||||||
|
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate
|
||||||
|
//
|
||||||
|
// Additionally, we currently cannot spawn a new top-level
|
||||||
|
// browsing context for new tab operations, because the new
|
||||||
|
// top-level browsing context would be in another process. To
|
||||||
|
// fix this, there needs to be some way to be able to
|
||||||
|
// communicate with browsing contexts in remote WebContent
|
||||||
|
// processes, and then step 8 of this algorithm needs to be
|
||||||
|
// implemented in BrowsingContext::choose_a_browsing_context:
|
||||||
|
//
|
||||||
|
// https://html.spec.whatwg.org/multipage/browsers.html#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name
|
||||||
|
if (RefPtr<HTML::HTMLAnchorElement> link = node->enclosing_link_element()) {
|
||||||
|
NonnullRefPtr document = *m_browsing_context.active_document();
|
||||||
|
auto href = link->href();
|
||||||
|
auto url = document->parse_url(href);
|
||||||
|
dbgln("Web::EventHandler: Clicking on a link to {}", url);
|
||||||
|
if (button == GUI::MouseButton::Primary) {
|
||||||
|
if (href.starts_with("javascript:")) {
|
||||||
|
document->run_javascript(href.substring_view(11, href.length() - 11));
|
||||||
|
} else if (!url.fragment().is_null() && url.equals(document->url(), AK::URL::ExcludeFragment::Yes)) {
|
||||||
|
m_browsing_context.scroll_to_anchor(url.fragment());
|
||||||
|
} else {
|
||||||
|
if (m_browsing_context.is_top_level()) {
|
||||||
|
if (auto* page = m_browsing_context.page())
|
||||||
|
page->client().page_did_click_link(url, link->target(), modifiers);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else if (button == GUI::MouseButton::Middle) {
|
||||||
|
if (auto* page = m_browsing_context.page())
|
||||||
|
page->client().page_did_middle_click_link(url, link->target(), modifiers);
|
||||||
|
} else if (button == GUI::MouseButton::Secondary) {
|
||||||
|
if (auto* page = m_browsing_context.page())
|
||||||
|
page->client().page_did_request_link_context_menu(m_browsing_context.to_top_level_position(position), url, link->target(), modifiers);
|
||||||
|
}
|
||||||
|
} else if (button == GUI::MouseButton::Secondary) {
|
||||||
|
if (is<HTML::HTMLImageElement>(*node)) {
|
||||||
|
auto& image_element = verify_cast<HTML::HTMLImageElement>(*node);
|
||||||
|
auto image_url = image_element.document().parse_url(image_element.src());
|
||||||
|
if (auto* page = m_browsing_context.page())
|
||||||
|
page->client().page_did_request_image_context_menu(m_browsing_context.to_top_level_position(position), image_url, "", modifiers, image_element.bitmap());
|
||||||
|
} else if (auto* page = m_browsing_context.page()) {
|
||||||
|
page->client().page_did_request_context_menu(m_browsing_context.to_top_level_position(position));
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue