mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-02 16:33:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

LibWeb/CSS: Give all style values a visit_edges() method

Browse source 
Having this hidden away in ImageStyleValue meant that
CSSStyleProperties (and anyone else who holds style values) had to know
exactly which types need visiting. This is a footgun waiting to happen,
so make this a virtual method on CSSStyleValue instead.
This commit is contained in:
Sam Atkins 2025-03-26 14:40:23 +00:00
parent c4bb74f40b
commit a2c89f585f
Notes: github-actions[bot] 2025-03-27 11:54:20 +00:00
4 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp
View file

@ -30,6 +30,7 @@ ImageStyleValue::~ImageStyleValue() = default;
void ImageStyleValue::visit_edges(JS::Cell::Visitor& visitor) const
{
Base::visit_edges(visitor);
// FIXME: visit_edges in non-GC allocated classes is confusing pattern.
// Consider making CSSStyleValue to be GC allocated instead.
visitor.visit(m_resource_request);