From a2fa3cbd69eee99aef14bde646940db75410a295 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 22 Feb 2025 14:51:34 +0100 Subject: [PATCH] LibWeb: Fix goofy layout tree dumps for NavigableContainerViewport We were neglecting to emit a newline before recursing into these. --- Libraries/LibWeb/Dump.cpp | 1 + .../misc/create-iframes-using-innerhtml.txt | 30 ++++++++++++------- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/Libraries/LibWeb/Dump.cpp b/Libraries/LibWeb/Dump.cpp index 33e735fb54d..55daea517a5 100644 --- a/Libraries/LibWeb/Dump.cpp +++ b/Libraries/LibWeb/Dump.cpp @@ -334,6 +334,7 @@ void dump_tree(StringBuilder& builder, Layout::Node const& layout_node, bool sho auto const& frame_box = static_cast(box); if (auto const* document = frame_box.dom_node().content_document_without_origin_check()) { builder.appendff(" (url: {})", document->url()); + builder.append("\n"sv); if (auto const* nested_layout_root = document->layout_node()) { ++indent; dump_tree(builder, *nested_layout_root, show_box_model, show_cascaded_properties, interactive); diff --git a/Tests/LibWeb/Layout/expected/misc/create-iframes-using-innerhtml.txt b/Tests/LibWeb/Layout/expected/misc/create-iframes-using-innerhtml.txt index 2b4731e81ab..a1e1b604a6b 100644 --- a/Tests/LibWeb/Layout/expected/misc/create-iframes-using-innerhtml.txt +++ b/Tests/LibWeb/Layout/expected/misc/create-iframes-using-innerhtml.txt @@ -13,43 +13,53 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline frag 7 from NavigableContainerViewport start: 0, length: 0, rect: [18,228 10x10] baseline: 30 frag 8 from NavigableContainerViewport start: 0, length: 0, rect: [18,258 10x10] baseline: 30 frag 9 from NavigableContainerViewport start: 0, length: 0, rect: [18,288 10x10] baseline: 30 - NavigableContainerViewport