mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-08 12:12:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Rename SharedImageRequest to SharedResourceRequest

Browse source 
For the SVG <use> element, we want to support loading HTML documents
that have a SVG element inside of it pointed to by the URL fragment.

In this situation we would need to fetch and parse the entire document
in SharedImageRequest (so that we can still cache the SVGs). Rename
SharedImageRequest to SharedResourceRequest to make the class a little
more generic for future usecases.
This commit is contained in:
Shannon Booth 2024-08-03 15:27:08 +12:00 • committed by Andreas Kling
parent 2fb5054603
commit a342370dfb
Notes: github-actions[bot] 2024-08-05 09:27:38 +00:00
18 changed files with 92 additions and 92 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -674,8 +674,8 @@ void HTMLImageElement::add_callbacks_to_image_request(JS::NonnullGCPtr<ImageRequ
image_request->add_callbacks(
[this, image_request, maybe_omit_events, url_string, previous_url]() {
batching_dispatcher().enqueue([this, image_request, maybe_omit_events, url_string, previous_url] {
VERIFY(image_request->shared_image_request());
auto image_data = image_request->shared_image_request()->image_data();
VERIFY(image_request->shared_resource_request());
auto image_data = image_request->shared_resource_request()->image_data();
image_request->set_image_data(image_data);
ListOfAvailableImages::Key key;
@ -884,8 +884,8 @@ void HTMLImageElement::react_to_changes_in_the_environment()
batching_dispatcher().enqueue([step_15, selected_source = move(selected_source), image_request, key] {
// 7. Otherwise, response's unsafe response is image request's image data. It can be either CORS-same-origin
// or CORS-cross-origin; this affects the image's interaction with other APIs (e.g., when used on a canvas).
VERIFY(image_request->shared_image_request());
auto image_data = image_request->shared_image_request()->image_data();
VERIFY(image_request->shared_resource_request());
auto image_data = image_request->shared_resource_request()->image_data();
image_request->set_image_data(image_data);
step_15(selected_source, image_request, key, *image_data);
});