From a37830362921eb03e5ff373aafb800703f5e1798 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 16 Mar 2024 07:59:48 +0100 Subject: [PATCH] LibWeb: Use unchecked_append in StyleComputer::collect_matching_rules() We already grow the "rules to run" vector before appending to it, so we can actually use unchecked_append() here and avoid the "needs to grow" checks every time we append to it. This takes appending from 3% to <1% when loading our GitHub repo. --- Userland/Libraries/LibWeb/CSS/StyleComputer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp b/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp index 3d7a496d3dc..de570b6c85f 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp +++ b/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp @@ -315,12 +315,12 @@ Vector StyleComputer::collect_matching_rules(DOM::Element const& e if (pseudo_element.has_value()) { for (auto const& rule : rules) { if (rule.contains_pseudo_element && filter_namespace_rule(element, rule)) - rules_to_run.append(rule); + rules_to_run.unchecked_append(rule); } } else { for (auto const& rule : rules) { if (filter_namespace_rule(element, rule)) - rules_to_run.append(rule); + rules_to_run.unchecked_append(rule); } } };