From a386ebde02a2a1993e15c9b55134c0f32b00ee86 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 16 Mar 2024 19:52:11 -0400 Subject: [PATCH] LibWeb: Do not return after ignoring a key event on an editable node We do not want to blindly say we handled the key event. Otherwise, the chrome is unable to handle shortcuts while an editable node is focused. --- Userland/Libraries/LibWeb/Page/EventHandler.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Page/EventHandler.cpp b/Userland/Libraries/LibWeb/Page/EventHandler.cpp index cc8350d1fc9..a79e0535b10 100644 --- a/Userland/Libraries/LibWeb/Page/EventHandler.cpp +++ b/Userland/Libraries/LibWeb/Page/EventHandler.cpp @@ -856,9 +856,6 @@ bool EventHandler::handle_keydown(KeyCode key, u32 modifiers, u32 code_point) m_browsing_context->increment_cursor_position_offset(); return true; } - - // NOTE: Because modifier keys should be ignored, we need to return true. - return true; } // FIXME: Work out and implement the difference between this and keydown.