mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-09-11 20:16:02 +00:00
LibWeb: Forbid scrolling of viewport if overflow=hidden
Before this change viewport was allowed to be scrolled whenever it has a scrollable overflow, which is not correct when overflow is specified to be hidden.
This commit is contained in:
parent
77761e123d
commit
a46c2a0887
Notes:
github-actions[bot]
2024-10-07 16:36:26 +00:00
Author: https://github.com/kalenikaliaksandr
Commit: a46c2a0887
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1667
1 changed files with 1 additions and 1 deletions
|
@ -240,7 +240,7 @@ bool PaintableBox::is_scrollable(ScrollDirection direction) const
|
|||
auto overflow = direction == ScrollDirection::Horizontal ? computed_values().overflow_x() : computed_values().overflow_y();
|
||||
auto scrollable_overflow_size = direction == ScrollDirection::Horizontal ? scrollable_overflow_rect()->width() : scrollable_overflow_rect()->height();
|
||||
auto scrollport_size = direction == ScrollDirection::Horizontal ? absolute_padding_box_rect().width() : absolute_padding_box_rect().height();
|
||||
if (is_viewport() || overflow == CSS::Overflow::Auto)
|
||||
if ((is_viewport() && overflow != CSS::Overflow::Hidden) || overflow == CSS::Overflow::Auto)
|
||||
return scrollable_overflow_size > scrollport_size;
|
||||
return overflow == CSS::Overflow::Scroll;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue