From a513bdaac6816a4a48ff74b0f9ff25838419bc11 Mon Sep 17 00:00:00 2001 From: Luke Wilde Date: Thu, 5 Dec 2024 11:06:23 +0000 Subject: [PATCH] LibWeb/WebGL: Implement bindRenderbuffer --- Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl | 2 +- .../CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl b/Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl index 4d03165c212..d682cfac178 100644 --- a/Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl +++ b/Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl @@ -49,7 +49,7 @@ interface mixin WebGLRenderingContextBase { undefined bindAttribLocation(WebGLProgram program, GLuint index, DOMString name); undefined bindBuffer(GLenum target, WebGLBuffer? buffer); undefined bindFramebuffer(GLenum target, WebGLFramebuffer? framebuffer); - [FIXME] undefined bindRenderbuffer(GLenum target, WebGLRenderbuffer? renderbuffer); + undefined bindRenderbuffer(GLenum target, WebGLRenderbuffer? renderbuffer); undefined bindTexture(GLenum target, WebGLTexture? texture); undefined blendColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha); undefined blendEquation(GLenum mode); diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp index 4c4b7477cc8..1f98d8dcb53 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp @@ -125,7 +125,7 @@ static void generate_get_parameter(SourceGenerator& generator) { "POLYGON_OFFSET_FILL"sv, { "GLboolean"sv } }, { "POLYGON_OFFSET_UNITS"sv, { "GLfloat"sv } }, { "RED_BITS"sv, { "GLint"sv } }, - // FIXME: { "RENDERBUFFER_BINDING"sv, { "WebGLRenderbuffer"sv } }, + { "RENDERBUFFER_BINDING"sv, { "WebGLRenderbuffer"sv } }, { "RENDERER"sv, { "DOMString"sv } }, { "SAMPLE_ALPHA_TO_COVERAGE"sv, { "GLboolean"sv } }, { "SAMPLE_BUFFERS"sv, { "GLint"sv } }, @@ -209,7 +209,7 @@ static void generate_get_parameter(SourceGenerator& generator) auto array_buffer = JS::ArrayBuffer::create(m_realm, move(byte_buffer)); return JS::@type_name@::create(m_realm, @element_count@, array_buffer); )~~~"); - } else if (type_name == "WebGLProgram"sv || type_name == "WebGLBuffer"sv || type_name == "WebGLTexture"sv || type_name == "WebGLFramebuffer"sv) { + } else if (type_name == "WebGLProgram"sv || type_name == "WebGLBuffer"sv || type_name == "WebGLTexture"sv || type_name == "WebGLFramebuffer"sv || type_name == "WebGLRenderbuffer"sv) { impl_generator.append(R"~~~( GLint result; glGetIntegerv(GL_@parameter_name@, &result);