LibJS: Remove DeprecatedFlyString::impl use in PrimitiveString

Author: https://github.com/DanShaders
Commit: a53911717f
Pull-request: https://github.com/SerenityOS/serenity/pull/22926
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/davidot ✅

Userland/Libraries/LibJS/Runtime/PrimitiveString.cpp

@@ -223,9 +223,7 @@ NonnullGCPtr<PrimitiveString> PrimitiveString::create(VM& vm, ByteString string)
 
 NonnullGCPtr<PrimitiveString> PrimitiveString::create(VM& vm, DeprecatedFlyString const& string)
 {
-    if (string.is_empty())
-        return vm.empty_string();
-    return create(vm, *string.impl());
+    return create(vm, ByteString { string });
 }
 
 NonnullGCPtr<PrimitiveString> PrimitiveString::create(VM& vm, PrimitiveString& lhs, PrimitiveString& rhs)