LibWeb: Use correct integer parsing rules in HTMLLIElement::value()

This commit is contained in:
Tim Ledbetter 2024-11-26 15:36:18 +00:00 committed by Andreas Kling
commit a61883ae88
Notes: github-actions[bot] 2024-11-26 18:51:19 +00:00
2 changed files with 16 additions and 2 deletions

View file

@ -8,6 +8,7 @@
#include <LibWeb/ARIA/Roles.h>
#include <LibWeb/HTML/HTMLElement.h>
#include <LibWeb/WebIDL/Types.h>
namespace Web::HTML {
@ -21,8 +22,8 @@ public:
// https://www.w3.org/TR/html-aria/#el-li
virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::listitem; }
i32 value() { return get_attribute(AttributeNames::value).value_or("0"_string).to_number<i32>().value_or(0); }
void set_value(i32 value)
WebIDL::Long value();
void set_value(WebIDL::Long value)
{
set_attribute(AttributeNames::value, String::number(value)).release_value_but_fixme_should_propagate_errors();
}