LibWeb: Resolve NavigatorBeacon FIXME regarding the partial interface

Author: https://github.com/gmta
Commit: a6dfc6cdff
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5559
Reviewed-by: https://github.com/AtkinsSJ ✅

Libraries/LibWeb/HTML/Navigator.h

@@ -22,7 +22,7 @@
 namespace Web::HTML {
 
 class Navigator : public Bindings::PlatformObject
-    , public NavigatorBeaconMixin
+    , public NavigatorBeaconPartial
     , public NavigatorConcurrentHardwareMixin
     , public NavigatorDeviceMemoryMixin
     , public NavigatorIDMixin

Libraries/LibWeb/HTML/Navigator.idl

@@ -71,7 +71,6 @@ interface mixin NavigatorAutomationInformation {
     readonly attribute boolean webdriver;
 };
 
-Navigator includes NavigatorBeacon;
 Navigator includes NavigatorID;
 Navigator includes NavigatorLanguage;
 Navigator includes NavigatorOnLine;

Libraries/LibWeb/HTML/NavigatorBeacon.cpp

@@ -17,7 +17,7 @@
 namespace Web::HTML {
 
 // https://w3c.github.io/beacon/#sendbeacon-method
-WebIDL::ExceptionOr<bool> NavigatorBeaconMixin::send_beacon(String const& url, Optional<Fetch::BodyInit> const& data)
+WebIDL::ExceptionOr<bool> NavigatorBeaconPartial::send_beacon(String const& url, Optional<Fetch::BodyInit> const& data)
 {
     auto& navigator = as<Navigator>(*this);
     auto& realm = navigator.realm();

Libraries/LibWeb/HTML/NavigatorBeacon.h

@@ -11,12 +11,12 @@
 
 namespace Web::HTML {
 
-class NavigatorBeaconMixin {
+class NavigatorBeaconPartial {
 public:
     WebIDL::ExceptionOr<bool> send_beacon(String const& url, Optional<Fetch::BodyInit> const& data = {});
 
 private:
-    virtual ~NavigatorBeaconMixin() = default;
+    virtual ~NavigatorBeaconPartial() = default;
 
     friend class Navigator;
 };

Libraries/LibWeb/HTML/NavigatorBeacon.idl

@@ -1,7 +1,6 @@
 #import <Fetch/BodyInit.idl>
 
 // https://w3c.github.io/beacon/#sendbeacon-method
-// FIXME: This is a partial interface not an interface mixin
-interface mixin NavigatorBeacon {
+partial interface Navigator {
     boolean sendBeacon(USVString url, optional BodyInit? data = null);
 };