LibWeb: Only set prototype once for object with IDL interface

Before this change, we were going through the chain of base classes for
each IDL interface object and having them set the prototype to their
prototype.

Instead of doing that, reorder things so that we set the right prototype
immediately in Foo::initialize(), and then don't bother in all the base
class overrides.

This knocks off a ~1% profile item on Speedometer 3.
This commit is contained in:
Andreas Kling 2025-04-20 16:22:57 +02:00 committed by Andreas Kling
commit a6dfc74e93
Notes: github-actions[bot] 2025-04-20 16:44:17 +00:00
417 changed files with 423 additions and 423 deletions

View file

@ -27,8 +27,8 @@ GC::Ref<IDBCursor> IDBCursor::create(JS::Realm& realm)
void IDBCursor::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBCursor);
Base::initialize(realm);
}
}

View file

@ -35,8 +35,8 @@ GC::Ref<IDBDatabase> IDBDatabase::create(JS::Realm& realm, Database& db)
void IDBDatabase::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBDatabase);
Base::initialize(realm);
}
void IDBDatabase::visit_edges(Visitor& visitor)

View file

@ -34,8 +34,8 @@ IDBFactory::~IDBFactory() = default;
void IDBFactory::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBFactory);
Base::initialize(realm);
}
// https://w3c.github.io/IndexedDB/#dom-idbfactory-open

View file

@ -31,8 +31,8 @@ GC::Ref<IDBIndex> IDBIndex::create(JS::Realm& realm, GC::Ref<Index> index, GC::R
void IDBIndex::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBIndex);
Base::initialize(realm);
}
void IDBIndex::visit_edges(Visitor& visitor)

View file

@ -33,8 +33,8 @@ GC::Ref<IDBKeyRange> IDBKeyRange::create(JS::Realm& realm, GC::Ptr<Key> lower_bo
void IDBKeyRange::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBKeyRange);
Base::initialize(realm);
}
void IDBKeyRange::visit_edges(Visitor& visitor)

View file

@ -33,8 +33,8 @@ GC::Ref<IDBObjectStore> IDBObjectStore::create(JS::Realm& realm, GC::Ref<ObjectS
void IDBObjectStore::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBObjectStore);
Base::initialize(realm);
}
void IDBObjectStore::visit_edges(Visitor& visitor)

View file

@ -25,8 +25,8 @@ IDBOpenDBRequest::IDBOpenDBRequest(JS::Realm& realm)
void IDBOpenDBRequest::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBOpenDBRequest);
Base::initialize(realm);
}
GC::Ref<IDBOpenDBRequest> IDBOpenDBRequest::create(JS::Realm& realm)

View file

@ -27,8 +27,8 @@ IDBRequest::IDBRequest(JS::Realm& realm, IDBRequestSource source)
void IDBRequest::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBRequest);
Base::initialize(realm);
}
GC::Ref<IDBRequest> IDBRequest::create(JS::Realm& realm, IDBRequestSource source)

View file

@ -35,8 +35,8 @@ GC::Ref<IDBTransaction> IDBTransaction::create(JS::Realm& realm, GC::Ref<IDBData
void IDBTransaction::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBTransaction);
Base::initialize(realm);
}
void IDBTransaction::visit_edges(Visitor& visitor)

View file

@ -29,8 +29,8 @@ IDBVersionChangeEvent::~IDBVersionChangeEvent() = default;
void IDBVersionChangeEvent::initialize(JS::Realm& realm)
{
Base::initialize(realm);
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBVersionChangeEvent);
Base::initialize(realm);
}
}