mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-25 11:48:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Fix Canvas.toDataURL and Canvas.toBlob signatures

Browse source 
Fix the function signatures of Canvas.toDataURL() and Canvas.toBlob()
and make both functions accept non-numbers as the quality parameter, in
which case it will just use the default quality instead of raising an
exception.
This makes toDataURL.arguments.1.html, toDataURL.arguments.2.html and
toDataURL.jpeg.quality.notnumber.html in
wpt/html/semantics/embedded-content/the-canvas-element pass :^)
This commit is contained in:
justus2510 2024-11-08 09:13:54 +01:00 • committed by Jelle Raaijmakers
commit a6e9f107eb
Notes: github-actions[bot] 2024-11-15 09:47:24 +00:00
4 changed files with 11 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/WebDriver/Screenshot.cpp
View file

@ -72,7 +72,7 @@ Response encode_canvas_element(HTML::HTMLCanvasElement& canvas)
// 3. Let file be a serialization of the canvas element’s bitmap as a file, using "image/png" as an argument.
// 4. Let data url be a data: URL representing file. [RFC2397]
auto data_url = canvas.to_data_url("image/png"sv, {});
auto data_url = canvas.to_data_url("image/png"sv, JS::js_undefined());
// 5. Let index be the index of "," in data url.
auto index = data_url.find_byte_offset(',');