mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-31 23:42:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK: Remove excessive hashing caused by FlyString table

Browse source 
Before this change, the global FlyString table looked like this:

    HashMap<StringView, Detail::StringBase>

After this change, we have:

    HashTable<Detail::StringData const*, FlyStringTableHashTraits>

The custom hash traits are used to extract the stored hash from
StringData which avoids having to rehash the StringView repeatedly like
we did before.

This necessitated a handful of smaller changes to make it work.
This commit is contained in:
Andreas Kling 2024-03-23 14:54:23 +01:00
parent 8bfad24708
commit a88799c032
Notes: sideshowbarker 2024-07-17 11:30:05 +09:00
6 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

28
AK/FlyString.cpp
View file

@ -8,14 +8,21 @@
#include <AK/FlyString.h>
#include <AK/HashMap.h>
#include <AK/Singleton.h>
#include <AK/String.h>
#include <AK/StringData.h>
#include <AK/StringView.h>
#include <AK/Utf8View.h>
namespace AK {
struct FlyStringTableHashTraits : public Traits<Detail::StringData const*> {
static u32 hash(Detail::StringData const* string) { return string->hash(); }
static bool equals(Detail::StringData const* a, Detail::StringData const* b) { return *a == *b; }
};
static auto& all_fly_strings()
{
static Singleton<HashMap<StringView, Detail::StringBase>> table;
static Singleton<HashTable<Detail::StringData const*, FlyStringTableHashTraits>> table;
return *table;
}
@ -31,14 +38,19 @@ FlyString::FlyString(String const& string)
return;
}
auto it = all_fly_strings().find(string.bytes_as_string_view());
if (string.m_data->is_fly_string()) {
m_data = string;
return;
}
auto it = all_fly_strings().find(string.m_data);
if (it == all_fly_strings().end()) {
m_data = string;
all_fly_strings().set(string.bytes_as_string_view(), m_data);
string.did_create_fly_string({});
all_fly_strings().set(string.m_data);
string.m_data->set_fly_string(true);
} else {
m_data = it->value;
m_data.m_data = *it;
m_data.m_data->ref();
}
}
@ -104,9 +116,9 @@ bool FlyString::operator==(char const* string) const
return bytes_as_string_view() == string;
}
void FlyString::did_destroy_fly_string_data(Badge<Detail::StringData>, StringView string_data)
void FlyString::did_destroy_fly_string_data(Badge<Detail::StringData>, Detail::StringData const& string_data)
{
all_fly_strings().remove(string_data);
all_fly_strings().remove(&string_data);
}
Detail::StringBase FlyString::data(Badge<String>) const