mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-28 23:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Make resolved serialization of CSS display prefer short form

Browse source 
Although we translate e.g `block` to `block flow` for internal use in
the engine, CSS-DISPLAY-3 tells us to use the short form in
serializations for compatibility reasons.

This adds 9 points to our score on https://html5test.com/ :^)
This commit is contained in:
Andreas Kling 2023-05-27 13:19:49 +02:00
parent 8defd55349
commit a98f5c7251
Notes: sideshowbarker 2024-07-17 07:25:39 +09:00
4 changed files with 90 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Userland/Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View file

@ -91,6 +91,35 @@ static ErrorOr<RefPtr<StyleValue>> style_value_for_display(CSS::Display display)
return IdentifierStyleValue::create(CSS::ValueID::None);
if (display.is_outside_and_inside()) {
// NOTE: Following the precedence rules of “most backwards-compatible, then shortest”,
// serialization of equivalent display values uses the “Short display” column.
if (display == CSS::Display::from_short(CSS::Display::Short::Block))
return IdentifierStyleValue::create(CSS::ValueID::Block);
if (display == CSS::Display::from_short(CSS::Display::Short::FlowRoot))
return IdentifierStyleValue::create(CSS::ValueID::FlowRoot);
if (display == CSS::Display::from_short(CSS::Display::Short::Inline))
return IdentifierStyleValue::create(CSS::ValueID::Inline);
if (display == CSS::Display::from_short(CSS::Display::Short::InlineBlock))
return IdentifierStyleValue::create(CSS::ValueID::InlineBlock);
if (display == CSS::Display::from_short(CSS::Display::Short::RunIn))
return IdentifierStyleValue::create(CSS::ValueID::RunIn);
if (display == CSS::Display::from_short(CSS::Display::Short::ListItem))
return IdentifierStyleValue::create(CSS::ValueID::ListItem);
if (display == CSS::Display::from_short(CSS::Display::Short::Flex))
return IdentifierStyleValue::create(CSS::ValueID::Flex);
if (display == CSS::Display::from_short(CSS::Display::Short::InlineFlex))
return IdentifierStyleValue::create(CSS::ValueID::InlineFlex);
if (display == CSS::Display::from_short(CSS::Display::Short::Grid))
return IdentifierStyleValue::create(CSS::ValueID::Grid);
if (display == CSS::Display::from_short(CSS::Display::Short::InlineGrid))
return IdentifierStyleValue::create(CSS::ValueID::InlineGrid);
if (display == CSS::Display::from_short(CSS::Display::Short::Ruby))
return IdentifierStyleValue::create(CSS::ValueID::Ruby);
if (display == CSS::Display::from_short(CSS::Display::Short::Table))
return IdentifierStyleValue::create(CSS::ValueID::Table);
if (display == CSS::Display::from_short(CSS::Display::Short::InlineTable))
return IdentifierStyleValue::create(CSS::ValueID::InlineTable);
StyleValueVector values;
switch (display.outside()) {
case CSS::Display::Outside::Inline: