LibGfx+LibWeb: Replace remaining OpenType implementation with Skia

This change should move us forward toward emoji support, as we are no longer limited by our own OpenType implementation, which was failing to parse the TrueType Collection format used to store emoji fonts (at least on macOS).
Author: https://github.com/kalenikaliaksandr Commit: a9d5a99568 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1278 Reviewed-by: https://github.com/trflynn89
2025-09-22 09:18:55 +00:00 · 2024-09-04 17:29:01 +02:00 · 2024-09-04 17:29:01 +02:00 · a9d5a99568 · 2024-09-05 17:22:50 +00:00
commit a9d5a99568
parent 99f64139d0
40 changed files with 309 additions and 3201 deletions
--- a/Tests/LibWeb/Layout/expected/css-line-height-zero.txt
+++ b/Tests/LibWeb/Layout/expected/css-line-height-zero.txt
@ -1,10 +1,10 @@
 Viewport <#document> at (0,0) content-size 800x600 children: not-inline
  BlockContainer <html> at (0,0) content-size 800x37 [BFC] children: not-inline
    BlockContainer <body> at (8,8) content-size 784x21 children: inline
-      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 191.875x19] baseline: 14.296875
-      BlockContainer <input> at (9,9) content-size 191.875x19 inline-block [BFC] children: not-inline
-        Box <div> at (11,10) content-size 187.875x17 flex-container(row) [FFC] children: not-inline
-          BlockContainer <div> at (11,10) content-size 187.875x17 flex-item [BFC] children: inline
+      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 200x19] baseline: 14.296875
+      BlockContainer <input> at (9,9) content-size 200x19 inline-block [BFC] children: not-inline
+        Box <div> at (11,10) content-size 196x17 flex-container(row) [FFC] children: not-inline
+          BlockContainer <div> at (11,10) content-size 196x17 flex-item [BFC] children: inline
            frag 0 from TextNode start: 0, length: 11, rect: [11,10 91.953125x17] baseline: 13.296875
                "Hello World"
            TextNode <#text>
@ -13,7 +13,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 ViewportPaintable (Viewport<#document>) [0,0 800x600]
  PaintableWithLines (BlockContainer<HTML>) [0,0 800x37]
    PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
-      PaintableWithLines (BlockContainer<INPUT>) [8,8 193.875x21]
-        PaintableBox (Box<DIV>) [9,9 191.875x19]
-          PaintableWithLines (BlockContainer<DIV>) [11,10 187.875x17]
+      PaintableWithLines (BlockContainer<INPUT>) [8,8 202x21]
+        PaintableBox (Box<DIV>) [9,9 200x19]
+          PaintableWithLines (BlockContainer<DIV>) [11,10 196x17]
            TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/css-pseudo-element-blockification.txt
+++ b/Tests/LibWeb/Layout/expected/css-pseudo-element-blockification.txt
@ -6,12 +6,12 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
          frag 0 from TextNode start: 0, length: 4, rect: [8,8 28.40625x17] baseline: 13.296875
              "well"
          TextNode <#text>
-        BlockContainer <(anonymous)> at (46,8) content-size 36.84375x17 flex-item [BFC] children: inline
-          frag 0 from TextNode start: 0, length: 5, rect: [46,8 36.84375x17] baseline: 13.296875
+        BlockContainer <(anonymous)> at (46.40625,8) content-size 36.84375x17 flex-item [BFC] children: inline
+          frag 0 from TextNode start: 0, length: 5, rect: [46.40625,8 36.84375x17] baseline: 13.296875
              "hello"
          TextNode <#text>
-        BlockContainer <(anonymous)> at (92.4375,8) content-size 55.359375x17 flex-item [BFC] children: inline
-          frag 0 from TextNode start: 0, length: 7, rect: [92.4375,8 55.359375x17] baseline: 13.296875
+        BlockContainer <(anonymous)> at (93.25,8) content-size 55.359375x17 flex-item [BFC] children: inline
+          frag 0 from TextNode start: 0, length: 7, rect: [93.25,8 55.359375x17] baseline: 13.296875
              "friends"
          TextNode <#text>

@ -21,7 +21,7 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
      PaintableBox (Box<DIV>.foo) [8,8 784x17]
        PaintableWithLines (BlockContainer(anonymous)) [8,8 28.40625x17]
          TextPaintable (TextNode<#text>)
-        PaintableWithLines (BlockContainer(anonymous)) [46,8 36.84375x17]
+        PaintableWithLines (BlockContainer(anonymous)) [46.40625,8 36.84375x17]
          TextPaintable (TextNode<#text>)
-        PaintableWithLines (BlockContainer(anonymous)) [92.4375,8 55.359375x17]
+        PaintableWithLines (BlockContainer(anonymous)) [93.25,8 55.359375x17]
          TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/font-size-zero.txt
+++ b/Tests/LibWeb/Layout/expected/font-size-zero.txt
@ -1,13 +1,13 @@
 Viewport <#document> at (0,0) content-size 800x600 children: not-inline
-  BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
-    BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
-      BlockContainer <div> at (8,8) content-size 784x0 children: inline
-        frag 0 from TextNode start: 0, length: 21, rect: [8,8 0x0] baseline: 0
+  BlockContainer <html> at (0,0) content-size 800x17 [BFC] children: not-inline
+    BlockContainer <body> at (8,8) content-size 784x1 children: not-inline
+      BlockContainer <div> at (8,8) content-size 784x1 children: inline
+        frag 0 from TextNode start: 0, length: 21, rect: [8,8 0x1] baseline: 0.796875
            "should not be visible"
        TextNode <#text>

 ViewportPaintable (Viewport<#document>) [0,0 800x600]
-  PaintableWithLines (BlockContainer<HTML>) [0,0 800x16]
-    PaintableWithLines (BlockContainer<BODY>) [8,8 784x0]
-      PaintableWithLines (BlockContainer<DIV>) [8,8 784x0]
+  PaintableWithLines (BlockContainer<HTML>) [0,0 800x17]
+    PaintableWithLines (BlockContainer<BODY>) [8,8 784x1]
+      PaintableWithLines (BlockContainer<DIV>) [8,8 784x1]
        TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/input-image-to-text.txt
+++ b/Tests/LibWeb/Layout/expected/input-image-to-text.txt
@ -1,10 +1,10 @@
 Viewport <#document> at (0,0) content-size 800x600 children: not-inline
  BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
    BlockContainer <body> at (8,8) content-size 784x21 children: inline
-      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 189.875x19] baseline: 14.296875
-      BlockContainer <input> at (9,9) content-size 189.875x19 inline-block [BFC] children: not-inline
-        Box <div> at (11,10) content-size 185.875x17 flex-container(row) [FFC] children: not-inline
-          BlockContainer <div> at (11,10) content-size 185.875x17 flex-item [BFC] children: inline
+      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 198x19] baseline: 14.296875
+      BlockContainer <input> at (9,9) content-size 198x19 inline-block [BFC] children: not-inline
+        Box <div> at (11,10) content-size 194x17 flex-container(row) [FFC] children: not-inline
+          BlockContainer <div> at (11,10) content-size 194x17 flex-item [BFC] children: inline
            frag 0 from TextNode start: 0, length: 7, rect: [11,10 55.6875x17] baseline: 13.296875
                "120.png"
            TextNode <#text>
@ -14,7 +14,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 ViewportPaintable (Viewport<#document>) [0,0 800x600]
  PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
    PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
-      PaintableWithLines (BlockContainer<INPUT>) [8,8 191.875x21]
-        PaintableBox (Box<DIV>) [9,9 189.875x19]
-          PaintableWithLines (BlockContainer<DIV>) [11,10 185.875x17]
+      PaintableWithLines (BlockContainer<INPUT>) [8,8 200x21]
+        PaintableBox (Box<DIV>) [9,9 198x19]
+          PaintableWithLines (BlockContainer<DIV>) [11,10 194x17]
            TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/input-password-to-text.txt
+++ b/Tests/LibWeb/Layout/expected/input-password-to-text.txt
@ -1,10 +1,10 @@
 Viewport <#document> at (0,0) content-size 800x600 children: not-inline
  BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
    BlockContainer <body> at (8,8) content-size 784x21 children: inline
-      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 189.875x19] baseline: 14.296875
-      BlockContainer <input> at (9,9) content-size 189.875x19 inline-block [BFC] children: not-inline
-        Box <div> at (11,10) content-size 185.875x17 flex-container(row) [FFC] children: not-inline
-          BlockContainer <div> at (11,10) content-size 185.875x17 flex-item [BFC] children: inline
+      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 198x19] baseline: 14.296875
+      BlockContainer <input> at (9,9) content-size 198x19 inline-block [BFC] children: not-inline
+        Box <div> at (11,10) content-size 194x17 flex-container(row) [FFC] children: not-inline
+          BlockContainer <div> at (11,10) content-size 194x17 flex-item [BFC] children: inline
            frag 0 from TextNode start: 0, length: 7, rect: [11,10 61.890625x17] baseline: 13.296875
                "hunter2"
            TextNode <#text>
@ -14,7 +14,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 ViewportPaintable (Viewport<#document>) [0,0 800x600]
  PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
    PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
-      PaintableWithLines (BlockContainer<INPUT>) [8,8 191.875x21]
-        PaintableBox (Box<DIV>) [9,9 189.875x19]
-          PaintableWithLines (BlockContainer<DIV>) [11,10 185.875x17]
+      PaintableWithLines (BlockContainer<INPUT>) [8,8 200x21]
+        PaintableBox (Box<DIV>) [9,9 198x19]
+          PaintableWithLines (BlockContainer<DIV>) [11,10 194x17]
            TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/input-text-to-password.txt
+++ b/Tests/LibWeb/Layout/expected/input-text-to-password.txt
@ -1,10 +1,10 @@
 Viewport <#document> at (0,0) content-size 800x600 children: not-inline
  BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
    BlockContainer <body> at (8,8) content-size 784x21 children: inline
-      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 189.875x19] baseline: 14.296875
-      BlockContainer <input> at (9,9) content-size 189.875x19 inline-block [BFC] children: not-inline
-        Box <div> at (11,10) content-size 185.875x17 flex-container(row) [FFC] children: not-inline
-          BlockContainer <div> at (11,10) content-size 185.875x17 flex-item [BFC] children: inline
+      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 198x19] baseline: 14.296875
+      BlockContainer <input> at (9,9) content-size 198x19 inline-block [BFC] children: not-inline
+        Box <div> at (11,10) content-size 194x17 flex-container(row) [FFC] children: not-inline
+          BlockContainer <div> at (11,10) content-size 194x17 flex-item [BFC] children: inline
            frag 0 from TextNode start: 0, length: 7, rect: [11,10 55.5625x17] baseline: 13.296875
                "*******"
            TextNode <#text>
@ -14,7 +14,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 ViewportPaintable (Viewport<#document>) [0,0 800x600]
  PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
    PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
-      PaintableWithLines (BlockContainer<INPUT>) [8,8 191.875x21]
-        PaintableBox (Box<DIV>) [9,9 189.875x19]
-          PaintableWithLines (BlockContainer<DIV>) [11,10 185.875x17]
+      PaintableWithLines (BlockContainer<INPUT>) [8,8 200x21]
+        PaintableBox (Box<DIV>) [9,9 198x19]
+          PaintableWithLines (BlockContainer<DIV>) [11,10 194x17]
            TextPaintable (TextNode<#text>)
--- a/Tests/LibWeb/Layout/expected/textarea-reset.txt
+++ b/Tests/LibWeb/Layout/expected/textarea-reset.txt
@ -2,11 +2,11 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
  BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
    BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
      BlockContainer <form#form> at (8,8) content-size 784x34 children: inline
-        frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 185.875x28] baseline: 16.296875
+        frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 194x28] baseline: 16.296875
        TextNode <#text>
-        BlockContainer <textarea#textarea> at (11,11) content-size 185.875x28 inline-block [BFC] children: not-inline
-          BlockContainer <div> at (11,11) content-size 185.875x17 children: not-inline
-            BlockContainer <div> at (11,11) content-size 185.875x17 children: inline
+        BlockContainer <textarea#textarea> at (11,11) content-size 194x28 inline-block [BFC] children: not-inline
+          BlockContainer <div> at (11,11) content-size 194x17 children: not-inline
+            BlockContainer <div> at (11,11) content-size 194x17 children: inline
              frag 0 from TextNode start: 0, length: 14, rect: [11,11 108.453125x17] baseline: 13.296875
                  "Original value"
              TextNode <#text>
@ -19,8 +19,8 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
  PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
    PaintableWithLines (BlockContainer<BODY>) [8,8 784x34] overflow: [8,8 784x50]
      PaintableWithLines (BlockContainer<FORM>#form) [8,8 784x34]
-        PaintableWithLines (BlockContainer<TEXTAREA>#textarea) [8,8 191.875x34]
-          PaintableWithLines (BlockContainer<DIV>) [11,11 185.875x17]
-            PaintableWithLines (BlockContainer<DIV>) [11,11 185.875x17]
+        PaintableWithLines (BlockContainer<TEXTAREA>#textarea) [8,8 200x34]
+          PaintableWithLines (BlockContainer<DIV>) [11,11 194x17]
+            PaintableWithLines (BlockContainer<DIV>) [11,11 194x17]
              TextPaintable (TextNode<#text>)
      PaintableWithLines (BlockContainer(anonymous)) [8,58 784x0]