mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 20:59:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Update "can have its URL rewritten" for spec changes

Browse source 
This updates the spec comments and removes a FIXME. Functionally,
this doesn't change anything as a fix was already in place.

See:
 - 89a387c
 - https://github.com/whatwg/html/issues/10551
This commit is contained in:
Jamie Mansfield 2024-08-17 13:27:35 +01:00 • committed by Andreas Kling
commit aac342bf74
Notes: github-actions[bot] 2024-08-20 18:40:10 +00:00
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/HTML/History.cpp
View file

@ -148,18 +148,20 @@ bool can_have_its_url_rewritten(DOM::Document const& document, URL::URL const& t
if (target_url.scheme() == "http"sv || target_url.scheme() == "https"sv)
return true;
// 4. If targetURL's scheme is "file", and targetURL and documentURL differ in their path component,
// then return false. (Differences in query and fragment are allowed for file: URLs.)
// FIXME: There's a bug in the spec here. We should return true if the scheme is "file" and the path components don't differ.
// Spec bug: https://github.com/whatwg/html/issues/10551
bool path_components_match = target_url.paths() == document_url.paths();
// 4. If targetURL's scheme is "file", then:
// (Differences in query and fragment are allowed for file: URLs.)
if (target_url.scheme() == "file"sv) {
return path_components_match;
// 1. If targetURL and documentURL differ in their path component, then return false.
if (target_url.paths() != document_url.paths())
return false;
// 2. Return true.
return true;
}
// 5. If targetURL and documentURL differ in their path component or query components, then return false.
// (Only differences in fragment are allowed for other types of URLs.)
if (!path_components_match || target_url.query() != document_url.query())
if (target_url.paths() != document_url.paths() || target_url.query() != document_url.query())
return false;
// 6. Return true.