mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-12 04:22:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Maintain tree order inside LayoutState

Browse source 
Before this change, we were at the mercy of hashed pointer addresses
when processing fragment relocation in LayoutState::commit().
This made inline fragment order non-deterministic, causing layouts to
shift around seemingly randomly on page reload.

By simply using OrderedHashMap, we automatically get tree order
processing here. This fixes a bunch of flaky tests on WPT.
This commit is contained in:
Andreas Kling 2025-05-19 13:18:10 +02:00 • committed by Jelle Raaijmakers
commit ab051f2e12
Notes: github-actions[bot] 2025-05-19 13:22:58 +00:00
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Layout/LayoutState.h
View file

@ -205,7 +205,7 @@ struct LayoutState {
UsedValues& get_mutable(NodeWithStyle const&);
UsedValues const& get(NodeWithStyle const&) const;
HashMap<GC::Ref<Layout::Node const>, NonnullOwnPtr<UsedValues>> used_values_per_layout_node;
OrderedHashMap<GC::Ref<Layout::Node const>, NonnullOwnPtr<UsedValues>> used_values_per_layout_node;
private:
void resolve_relative_positions();

17
Tests/LibWeb/Layout/expected/inline-fragment-ordering-flakiness.txt Normal file
View file

@ -0,0 +1,17 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x18 [BFC] children: inline
InlineNode <body>
frag 0 from BlockContainer start: 0, length: 0, rect: [8,0 36.84375x18] baseline: 13.796875
frag 1 from TextNode start: 0, length: 5, rect: [8,0 36.84375x18] baseline: 13.796875
"hello"
BlockContainer <main> at (8,0) content-size 36.84375x18 inline-block [BFC] children: not-inline
BlockContainer <div> at (8,0) content-size 36.84375x18 children: inline
TextNode <#text>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x18]
PaintableWithLines (InlineNode<BODY>)
PaintableWithLines (BlockContainer<MAIN>) [8,0 36.84375x18]
PaintableWithLines (BlockContainer<DIV>) [8,0 36.84375x18]
TextPaintable (TextNode<#text>)

9
Tests/LibWeb/Layout/input/inline-fragment-ordering-flakiness.html Normal file
View file

@ -0,0 +1,9 @@
<!doctype html><html><head><style>
body {
display: inline;
position: relative;
}
main {
display: inline-block;
}
</style></head><body><main><div>hello</div></main></body></html>