Browser: Use String::count instead of String::replace(X, X, true)

There's no need to create a new String just to count the amount of occurrences of a substring.
Author: https://github.com/IdanHo Commit: aba4c9579f Pull-request: https://github.com/SerenityOS/serenity/pull/9948 Reviewed-by: https://github.com/alimpfard Reviewed-by: https://github.com/bgianfo ✅
2025-09-01 15:18:06 +00:00 · 2021-09-11 01:04:08 +03:00 · 2021-09-11 01:04:08 +03:00 · aba4c9579f · 2024-07-18 04:15:05 +09:00
commit aba4c9579f
parent 6d2b003b6e
1 changed files with 1 additions and 1 deletions
--- a/Userland/Applications/Browser/BrowserWindow.cpp
+++ b/Userland/Applications/Browser/BrowserWindow.cpp
@ -280,7 +280,7 @@ void BrowserWindow::build_menus()
            return;
        }

-        int argument_count = search_engine.replace("{}", "{}", true);
+        auto argument_count = search_engine.count("{}"sv);
        if (argument_count != 1) {
            GUI::MessageBox::show(this, "Invalid format, must contain '{}' once!", "Error", GUI::MessageBox::Type::Error);
            m_disable_search_engine_action->activate();